Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-24869: Refactor view providers to match the new interfaces #38

Merged

Conversation

4 participants
@emodric
Copy link
Collaborator

commented Oct 10, 2015

This PR refactors legacy view providers to use the new interafaces which work with View objects.

Depends on ezsystems/ezpublish-kernel#1454

This refactor also fixes issue with fallback to legacy view providers detailed in ezsystems/ezpublish-kernel#1451. However, that issue should still be considered for 5.4, since fallback to legacy view providers in 5.4 will remain broken.

@emodric emodric force-pushed the emodric:ezp24869-viewController_refactoring branch from d77fde7 to 3d949d2 Oct 10, 2015

@emodric

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 15, 2015

Ping @lolautruche @bdunogier now that required ez kernel PR is merged :)

@andrerom

This comment has been minimized.

Copy link
Member

commented Oct 15, 2015

Seem to fail :/

@emodric

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 15, 2015

Not related to this change :)

@Plopix

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2015

@andrerom @emodric Works well for me!

@emodric

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 17, 2015

@andrerom @Plopix Yep, I'm running this branch for a while now :)

@andrerom

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

+1 but @bdunogier should review

@bdunogier

This comment has been minimized.

Copy link
Member

commented Oct 21, 2015

Tested, looks good. Thanks a lot, @emodric.

bdunogier added a commit that referenced this pull request Oct 21, 2015

Merge pull request #38 from emodric/ezp24869-viewController_refactoring
EZP-24869: Refactor view providers to match the new interfaces

@bdunogier bdunogier merged commit 56c65f8 into ezsystems:master Oct 21, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ezrobot Code review by ezrobot
Details
@emodric

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 21, 2015

Thank you @bdunogier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.