EZP-24626 As an editor I want to see content type description when editing content #292
Conversation
|
ready for review @dpobel @mhyndle @yannickroger |
StephaneDiot
force-pushed
the
EZP-24626_Content_type_description_when_editing
branch
2 times, most recently
from
7bc8f11
to
4aaaf8d
Compare
| @@ -53,6 +56,18 @@ YUI.add('ez-contenteditview', function (Y) { | |||
| } | |||
| }); | |||
|
|
|||
| this.after('activeChange', function (e) { | |||
| if ( e.newVal ) { | |||
| that._attachedViewEvents.push( | |||
There was a problem hiding this comment.
this is perfectly usable here and given the complexity of the code, that would deserve an external method
StephaneDiot
force-pushed
the
EZP-24626_Content_type_description_when_editing
branch
from
4aaaf8d
to
76d296c
Compare
|
You can rebase on master to get rid of the ezrobot warning. |
StephaneDiot
force-pushed
the
EZP-24626_Content_type_description_when_editing
branch
from
76d296c
to
5f8d233
Compare
| <div class="ez-infos"> | ||
| <ul class="ez-technical-infos"> | ||
| <li>{{ contentType.names.[eng-GB] }}</li> | ||
| <li>Created by {{ owner.name }}</li> |
There was a problem hiding this comment.
Should this be a translateable string?
There was a problem hiding this comment.
This might be because it is ContentInfo object underneath, if so something we would have to fix later. Or @StephaneDiot ?
|
+1 apart from question above. |
|
+1 |
| * @protected | ||
| * @param {Object} e event facade | ||
| */ | ||
| _removeInfos: function (e) { |
There was a problem hiding this comment.
this is a very bad name (and description in the comment). This method does not remove anything, it sets an event handler on the clickoutside event that will hide the infos. So please rename it to something like _addClickoutsideInfoHandler and use _hideDetails instead of reimplementing it in an anonymous function.
StephaneDiot
force-pushed
the
EZP-24626_Content_type_description_when_editing
branch
from
5f8d233
to
cd11ee6
Compare
|
updated ! @dpobel |
|
+1 |
…ription_when_editing EZP-24626 As an editor I want to see content type description when editing content
https://jira.ez.no/browse/EZP-24626
Description
A description of the content type should be shown when passing cursor over the header while editing or creating a content. On 'touch friendly' devices the description should be shown when tapping on header, and should unshow when tapping outside (the same rule has also been added for the technical infos).
Screencast
http://youtu.be/Y97RexOHWZo
(first part is 'touch friendly' emulated, second is like in a normal browser)