Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-25108: As an editor, I want to able to embed images in the RichText editor #436

Merged
merged 14 commits into from Nov 25, 2015

Conversation

4 participants
@dpobel
Copy link
Contributor

dpobel commented Nov 19, 2015

JIRA: https://jira.ez.no/browse/EZP-25108

Description

This patch adds the ability to add images in the RichText editor. It's basically a specific UI to embed contents with a filled ezimage field. It only provides the very basic feature.

Screencast: http://youtu.be/-JIZIAIQ-W8

Out of the scope of this PR / Bugs / Follow up

Tasks

  • Add an option to the UDW so it can provide the Content
  • Improve the ezembed widget API to consistently handle those widgets with the buttons
  • Add a way to configure the event that are forwarded from the editor the YUI stack
  • Add a custom callback to the loadImageVariation event
  • Add a method in ContentType model to get the field identifier of a given type
  • Add the Image button
  • Add the config the Image styling toolbar
  • Add the change Image button for embed representing an image
  • CSS
  • Smooth transition/interaction moved to EZP-25138 as the PR is already too big.
  • Create the follow up stories/improvements

Tests

manual tests + unit test

@dpobel dpobel force-pushed the ezp-25108_editor_image branch from 9423ce5 to baaa031 Nov 20, 2015

@dpobel dpobel force-pushed the ezp-25108_editor_image branch from baaa031 to 5ab770a Nov 23, 2015

@dpobel dpobel force-pushed the ezp-25108_editor_image branch from 5ab770a to 2e52b8b Nov 23, 2015

@dpobel dpobel changed the title [WIP] As an editor, I want to able to embed images in the RichText editor EZP-25108: As an editor, I want to able to embed images in the RichText editor Nov 23, 2015

@dpobel

This comment has been minimized.

Copy link
Contributor Author

dpobel commented Nov 23, 2015

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Nov 24, 2015

+0.99

@yannickroger

This comment has been minimized.

Copy link
Contributor

yannickroger commented Nov 24, 2015

+1.0099999999999999999999999999999999999999999999999999999 :)

@dpobel

This comment has been minimized.

Copy link
Contributor Author

dpobel commented Nov 24, 2015

for the record:

$ node -e 'console.log(+0.99 + +1.0099999999999999999999999999999999999999999999999999999)'
2
@mhyndle

This comment has been minimized.

Copy link
Contributor

mhyndle commented Nov 25, 2015

+1

@mhyndle mhyndle closed this Nov 25, 2015

@mhyndle mhyndle reopened this Nov 25, 2015

@mhyndle

This comment has been minimized.

Copy link
Contributor

mhyndle commented Nov 25, 2015

Sorry, missclicked (need coffee).
+1

dpobel added a commit that referenced this pull request Nov 25, 2015

Merge pull request #436 from ezsystems/ezp-25108_editor_image
EZP-25108: As an editor, I want to able to embed images in the RichText editor

@dpobel dpobel merged commit 5afceb4 into master Nov 25, 2015

2 of 3 checks passed

ez/ci/behat Behat test execution by ezrobot
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot Code review by ezrobot
Details

@dpobel dpobel deleted the ezp-25108_editor_image branch Nov 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.