Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-25177: search result persist after UDW reloads #451

Merged
merged 1 commit into from Dec 4, 2015

Conversation

@mhyndle
Copy link
Contributor

mhyndle commented Dec 2, 2015

status: ready for review

Jira: https://jira.ez.no/browse/EZP-25177

Description

While investigating the problem I found 2 things that were involved in generating the problem:

  • this._fireLocationSearch was triggered on change of 2 attributes: offset and searchText so there were 2 almost simultaneus calls when new search was started - one with changed searchText (but still with old offset) and just after that the second one with reseted offset. So displayed results can be randomly from first or second search...
    To solve this one I have stopped listening on offsetChange and call this._fireLocationSearch for every page change.
  • As there is locationSearch triggered on searchTextChange event so when the view is being reset the problems also happens. So just after UDW was being closed the locationSearch call was triggered. Instead, the view should be reset. That's what this PR also provides - when the searchText is empty, instead of calling locationSearch, the view is being reset ({offset: 0; searchResultCount: 0; searchResultList: []}).

Tasks

  • implementation
  • unit tests
@mhyndle mhyndle changed the title Fix EZP-25177: search result persist after UDW reloads [WIP] Fix EZP-25177: search result persist after UDW reloads Dec 2, 2015
@mhyndle mhyndle changed the title [WIP] Fix EZP-25177: search result persist after UDW reloads Fix EZP-25177: search result persist after UDW reloads Dec 3, 2015
@mhyndle

This comment has been minimized.

Copy link
Contributor Author

mhyndle commented Dec 3, 2015

Ready for review
ping @dpobel @yannickroger @StephaneDiot

@StephaneDiot

This comment has been minimized.

Copy link
Contributor

StephaneDiot commented Dec 3, 2015

+1

1 similar comment
@dpobel

This comment has been minimized.

Copy link
Contributor

dpobel commented Dec 4, 2015

+1

mhyndle added a commit that referenced this pull request Dec 4, 2015
…istance_after_udw_reloads

Fix EZP-25177: search result persist after UDW reloads
@mhyndle mhyndle merged commit f751338 into ezsystems:master Dec 4, 2015
2 of 3 checks passed
2 of 3 checks passed
ez/ci/behat Behat test execution by ezrobot
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot Code review by ezrobot
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.