Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-25175: Setting incorrect pagination offset in subitems view #452

Conversation

3 participants
@StephaneDiot
Copy link
Contributor

commented Dec 3, 2015

jira: https://jira.ez.no/browse/EZP-25175

Description

When a folder had as many children as a multiple of its subitems list limit per page, the subitems list would not show if you try to go to the last page. The reason of that is incorrect calculation for offset for last page which fails in case when total number of results is multiplication of page limit.

Tests

  • Manual tests
  • Unit tests
@StephaneDiot

This comment has been minimized.

Copy link
Contributor Author

commented Dec 3, 2015

@mhyndle

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2015

+1 as far as Travis agree

@dpobel

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2015

+1 (Travis and ezrobot agree)

StephaneDiot added a commit that referenced this pull request Dec 3, 2015

Merge pull request #452 from StephaneDiot/EZP-25175_Incorect_paginati…
…on_sub_items

Fix EZP-25175: Setting incorrect pagination offset in subitems view

@StephaneDiot StephaneDiot merged commit 630851e into ezsystems:master Dec 3, 2015

2 of 3 checks passed

ez/ci/behat Behat test execution by ezrobot
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot Code review by ezrobot
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.