Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-26117: Required richtext not validated as filled with single embed #667

Merged
merged 1 commit into from Aug 30, 2016

Conversation

@yannickroger
Copy link
Contributor

commented Aug 29, 2016

Link: https://jira.ez.no/browse/EZP-26117

Description

When editing a content with a mandatory richtext field (such as article). If only an single embed is present, the field is still considered empty.

Test

Manual and unit tests

@andrerom

This comment has been minimized.

Copy link
Member

commented Aug 29, 2016

+1

@@ -241,9 +241,12 @@ YUI.add('ez-richtext-editview', function (Y) {
return element.get('children').some(function (node) {
return L.trim(node.get('text')) !== '';
});
},
hasChildWithEmbed = function(element) {

This comment has been minimized.

Copy link
@dpobel

dpobel Aug 29, 2016

Contributor

I would call it hasEmbedElement

@dpobel

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2016

beside the nitpick on the name, +1

@yannickroger yannickroger force-pushed the ezp-26117-embeded_richtext_empty branch from ea51ffe to dd34410 Aug 30, 2016

@yannickroger yannickroger merged commit b669222 into 1.4 Aug 30, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot Code review by ezrobot
Details

@yannickroger yannickroger deleted the ezp-26117-embeded_richtext_empty branch Aug 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.