Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-28030: Alloy editor add support for more builtin buttons #905

Merged
merged 3 commits into from Oct 10, 2017

Conversation

5 participants
@Plopix
Copy link
Contributor

Plopix commented Sep 22, 2017

https://jira.ez.no/browse/EZP-28030

This PR adds 'subscript', 'superscript', 'quote', 'strike', and 'numbered list'
Enjoy
screen shot 2017-09-21 at 6 49 53 pm
screen shot 2017-09-21 at 6 55 54 pm

Todo:

  • make sure kernel can parse/ output all the added syntax

@andrerom andrerom requested review from sunpietro and dew326 Oct 3, 2017

*
* @class eZ.AlloyEditor.ButtonList
*/
ButtonList = React.createClass({displayName: "ButtonListIndexed",

This comment has been minimized.

Copy link
@dew326

dew326 Oct 4, 2017

Member

I think something is wrong with this generated js. I think this should be ButtonListIndexed = ... instead of ButtonList = ...

@andrerom andrerom self-assigned this Oct 4, 2017

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Oct 4, 2017

Fixed the wrongly generated js.

@Plopix did you test this extensively btw? was the format properly saved to richtext and back to view and edit?

@dew326 looks ok? If so we can potentially send to QA to make sure proper testing is done.
In parallel one of us can try to add some unit tests so this is ready for merge if it passes.

@dew326

This comment has been minimized.

Copy link
Member

dew326 commented Oct 5, 2017

@andrerom now it looks ok and I think we can send this to QA.
About testing, I will not be able to focus on this in the current sprint (it's hard to add something extra into the sprint since we are more to scrum).
Let me know if you can handle this or should we try to add this to the upcoming sprint.

@andrerom andrerom changed the title Alloy editor - free button additions EZP-28030: Alloy editor add support for more builtin buttons Oct 5, 2017

@micszo

This comment has been minimized.

Copy link
Member

micszo commented Oct 6, 2017

As a smoke test I tried using the new numbered list feature but it looks like there is work on backend needed - XML validation error occurs:
screen shot 2017-10-06 at 10 31 50

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Oct 6, 2017

Thanks @micszo, then we will probably keep this for 1.13 release, it needs a deeper look and work on kernel.

@andrerom andrerom removed the Ready for QA label Oct 6, 2017

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Oct 8, 2017

@micszo Tested and only found issues with striked: ezsystems/ezpublish-kernel#2103

What browser did you use?

@micszo

This comment has been minimized.

Copy link
Member

micszo commented Oct 8, 2017

I used Chrome.

@Plopix

This comment has been minimized.

Copy link
Contributor Author

Plopix commented Oct 9, 2017

@andrerom it is in prod for on EE project. I tested the basics, store, edit, view.
I did not test extensively on all the browser though.

@mnocon

mnocon approved these changes Oct 10, 2017

Copy link
Member

mnocon left a comment

Looks good: checked editing, viewing and modifying on multiple browsers (Chrome, Safari, Firefox). Tested briefly on Edge, needs broader testing during certification.

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Oct 10, 2017

Thanks @mnocon !

Followups:

  • further testing to try to identify issue reported above
  • add unit tests

@andrerom andrerom merged commit 47de3d3 into ezsystems:master Oct 10, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ezrobot/csslint Code review by ezrobot
Details
ezrobot/jshint Code review by ezrobot
Details
ezrobot/phpcsfixer Code review by ezrobot
Details
ezrobot/yuidoc Code review by ezrobot
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.