Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-27609: Update doc on Doctrine for Field Types external storage #19

Merged
merged 1 commit into from Aug 22, 2017

Conversation

3 participants
@DominikaK
Copy link
Contributor

DominikaK commented Aug 7, 2017

@DominikaK DominikaK requested a review from kusztel Aug 7, 2017

@DominikaK

This comment has been minimized.

Copy link
Contributor Author

DominikaK commented Aug 7, 2017

ping @alongosz

tags:
- {name: ezpublish.fieldType.externalStorageHandler, alias: ezurl}
```

The configuration is straight forward. Nothing specific except the **`ezpublish.fieldType.externalStorageHandler `** tag, the `alias` attribute still begin the *fieldTypeIdentifier*.
The configuration requires providing the **`ezpublish.fieldType.externalStorageHandler `** tag, with the `alias` attribute being the *fieldTypeIdentifier*. You also have to inject the gateway in the `arguments` tag, [see below](#gateway-based-storage_1).

This comment has been minimized.

Copy link
@alongosz

alongosz Aug 7, 2017

Member

I wouldn't call arguments key a "tag". Tag is a keyword in Symfony DI Container domain. Either "pass a gateway service definition as an argument" or just remove word "tag" (to me, sounds good w/o it as well).

This comment has been minimized.

Copy link
@alongosz

alongosz Aug 7, 2017

Member

#gateway-based-storage-1, right?


##### Gateway based storage

As stated in the [Field Type best practices](#gateway-based-storage), in order to be storage agnostic and external storage handler should use a *storage gateway*. This can be done by implementing another service implementing `eZ\Publish\Core\FieldType\StorageGateway` and being tagged as `ezpublish.fieldType.externalStorageHandler.gateway`.
As stated in the [Field Type best practices](#gateway-based-storage), in order to be storage agnostic and external storage handler should use a *storage gateway*. This can be done using another service implementing `eZ\Publish\SPI\FieldType\StorageGateway`, to be injected into external storage handler ([see above](#external-storage)).

**Storage gateway for ezurl**

This comment has been minimized.

Copy link
@alongosz

alongosz Aug 7, 2017

Member

The yml code below this, which I'm unable to review here, also needs to be changed. Please see the proper yml. Doc further refers to connection argument. Also tagging disappeared as is no longer needed (gateway gets injected in the code mentioned above).

@DominikaK DominikaK force-pushed the DominikaK:ezp-27609-doctrine-field-types branch from 4e951b7 to 68f9b14 Aug 8, 2017

@kusztel kusztel merged commit 50c87d3 into ezsystems:1.11 Aug 22, 2017

@DominikaK DominikaK deleted the DominikaK:ezp-27609-doctrine-field-types branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.