Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add PHP 7.3 preview (xdebug in rc version) #32
First failure: difference in libzip usage during build, could have given it options to use bundled version but UPGRADE suggests not doing that
Second failure: Blackfire not found for 7.3, 1h after the build they tweeted support was added.
Third failure: xdebug, trying beta channel even if that is from september, but results in app_1 |
memcached 3.1.0 is released!
mnocon left a comment
Looks good to me.
One question that came to my mind, not really related to this PR:
Does it mean, that for v2 testing this line https://github.com/ezsystems/docker-php/pull/32/files#diff-6757d9ef6e7f3b3c85ea7eb11b9af47fR84 should be changed and PHP_IMAGE should be set based on EZ_VERSION (ez_php:latest for v1 and ez_php:latest-node for testing on version 2.5)? If yes I can create a follow-up for that.
Feb 13, 2019
1 check passed
Good catch: e7534b3
So just fixing the env variables won't do.
Yes, it is possible. Something like:
builds the image with Node flavour.
I'll amend my PR with that and ping you there, thanks!