Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29796: Legacy transaction handling issues #27

Merged
merged 4 commits into from Feb 15, 2019

Conversation

4 participants
@glye
Copy link
Member

glye commented Jul 26, 2018

EZP-28681: Legacy transaction handling issues
1. Status change during autosave

@glye glye referenced this pull request Jul 30, 2018

Closed

[WIP] EZP-28681: Legacy transaction handling issues #1380

2 of 5 tasks complete

@glye glye changed the title [WIP] EZP-28681: Legacy transaction handling issues [WIP] EZP-29796: Legacy transaction handling issues Nov 9, 2018

@glye

This comment has been minimized.

Copy link
Member Author

glye commented Jan 3, 2019

Status: Storing content and version should be safer with this code, but it is not complete. There are so many queries happening, since content attributes are also saved. Fixing those will require changes to datatype API, and extra implementation for some types.

@micszo

micszo approved these changes Feb 11, 2019

Copy link
Member

micszo left a comment

Retested successfully on v5.3.12.1 with diff.
Tested together with diff from ezsystems/ezpublish-legacy#1415.

@glye glye changed the title [WIP] EZP-29796: Legacy transaction handling issues EZP-29796: Legacy transaction handling issues Feb 15, 2019

@glye glye merged commit 733aa9e into master Feb 15, 2019

@glye glye deleted the ezp28681_legacy_transaction_handling branch Feb 15, 2019

@@ -132,6 +141,7 @@ static public function saveDraft( $args )
$language = eZContentLanguage::fetchByLocale( $editLanguage );
if ( !$language instanceof eZContentLanguage )
{
$db->commit();

This comment has been minimized.

@andrerom

andrerom Feb 18, 2019

Member

shouldn't all these new cases with commits actually be rollback or similar given they are error conditions?

This comment has been minimized.

@glye

glye Feb 18, 2019

Author Member

No, this is on purpose. Better to do an empty commit, than risk outer commits being rolled back.

This comment has been minimized.

@andrerom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.