Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-22859: Object Relations versions not saved correctly in Solr #163

Merged
merged 1 commit into from Jun 2, 2014

Conversation

@yannickroger
Copy link
Contributor

commented May 30, 2014

Link: https://jira.ez.no/browse/EZP-22859

Description

While indexing object relations, ezfind was using object versions contained in the attribute's xml_data field. The problem is that this version is the version of the object when it was first added to the relation, not the current one. This patch fixes this by fetching the current object instead of the version from the xml_data.

Tests

Manual tests

@lolautruche

This comment has been minimized.

Copy link
Contributor

commented May 30, 2014

+1

@bdunogier

This comment has been minimized.

Copy link
Member

commented May 30, 2014

I'm not sure I have enough to context to give a +1, but here's one (looks fine if the symptoms were correctly analyzed).

@andrerom

This comment has been minimized.

Copy link
Member

commented May 31, 2014

+1

@nfrp Any objections? :)

@nfrp

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2014

After a snap look, the new logic looks legit to me.

+1

yannickroger added a commit that referenced this pull request Jun 2, 2014
Merge pull request #163 from ezsystems/ezp-22859-object_relations
Fix EZP-22859: Object Relations versions not saved correctly in Solr

@yannickroger yannickroger merged commit d79ebcd into master Jun 2, 2014

@yannickroger yannickroger deleted the ezp-22859-object_relations branch Jun 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.