EZP-26804: Search with section id list filter #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunogier
requested changes
Jan 2, 2017
classes/ezfezpsolrquerybuilder.php
Outdated
| @@ -1530,6 +1531,53 @@ protected function getContentClassFilterQuery( $contentClassIdent ) | |||
| } | |||
|
|
|||
| /** | |||
| * Generate section query filter. | |||
| * | |||
| * @param mixed eZSection id or list of ids. | |||
There was a problem hiding this comment.
@param int|int[] $sectionIdent eZSection id or list of ids.
classes/ezfezpsolrquerybuilder.php
Outdated
| * @param mixed eZSection id or list of ids. | ||
| * | ||
| * @return string Section query filter. Returns null if invalid | ||
| * $sectionIdent is provided. |
There was a problem hiding this comment.
You need to align the second line with string.
classes/ezfezpsolrquerybuilder.php
Outdated
|
|
||
| return implode( ' OR ', $sectionQueryParts ); | ||
| } | ||
| elseif ( (int)$sectionIdent . '' == $sectionIdent . '' ) |
There was a problem hiding this comment.
I'd handle this case first as it is the most common. Then I'd get rid of the else, as we return inside the if.
blankse
changed the title
|
@bdunogier I take your remarks into account :) |
bdunogier
requested changes
Jan 26, 2017
classes/ezfezpsolrquerybuilder.php
Outdated
| { | ||
| return eZSolr::getMetaFieldName( 'section_id' ) . ':' . $sectionIdent; | ||
| } | ||
| elseif ( is_array( $sectionIdent ) ) |
There was a problem hiding this comment.
You don't need the else, since you return in the if above.
|
@bdunogier I removed the else |
|
Ping @bdunogier |
andrerom
reviewed
Dec 5, 2017
classes/ezfezpsolrquerybuilder.php
Outdated
| foreach ( $sectionIdent as $sectionID ) | ||
| { | ||
| $sectionID = trim( $sectionID ); | ||
| if ( empty( $sectionID ) ) |
There was a problem hiding this comment.
Is empty array value something we need to support? it could just go straight to error, or?
gggeek
reviewed
Dec 6, 2017
classes/ezfezpsolrquerybuilder.php
Outdated
| return null; | ||
| } | ||
|
|
||
| if ( is_numeric( $sectionIdent ) ) |
There was a problem hiding this comment.
might be better to use ctype_digit()
|
Beside remark, +1 |
andrerom
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-26804