Skip to content
This repository was archived by the owner on Sep 3, 2026. It is now read-only.

Adds a new search feature 'fields_to_search' - #93

Closed
harmstyler wants to merge 5 commits into
ezsystems:masterfrom
harmstyler:feature_search_field
Closed

harmstyler wants to merge 5 commits into
ezsystems:masterfrom
harmstyler:feature_search_field

Conversation

@harmstyler

Copy link
Copy Markdown

Adds the new feature to give users more control over what is searched. Searching fewer fields can also lower search times.

The $highlightParams variable was unused in the query builder script. This update gives the ability to declare custom highlight fields at both query time and in the eZ Find ini. If there are no custom highlight fields given the $highLightFields variable is then populated with the $queryFields.
Conflicts:
	classes/ezfmodulefunctioncollection.php
	java/webapps/solr.war
	modules/ezfind/function_definition.php
Adds the new feature to give users more control over what is searched. Searching fewer fields can also lower search times.
@nfrp

nfrp commented Dec 13, 2012

Copy link
Copy Markdown
Contributor

Hi Tyler and thanks for the contribution!

I see that an possibly unrelated commit made its way into this pull-request ( 0e66c8b ). Might need to be isolated.

Concerning the search fields addition: if I understand the code correctly, it means that the fully-qualified names of the search fields must be provided, right? In other words, it would not be possible to use the following syntax:
article/body
Do you confirm?

Cheers,

@harmstyler

Copy link
Copy Markdown
Author

Agreed, I will remove the new war file, that was a mistake.

Yes, at the moment you need to know the solr field you are searching for, article/body will not work.

@harmstyler harmstyler closed this Apr 16, 2013
@harmstyler
harmstyler deleted the feature_search_field branch April 16, 2013 20:40
@nfrp

nfrp commented Apr 17, 2013

Copy link
Copy Markdown
Contributor

Hi Tyler,

I see you just closed the pull-request, we are sorry of the processing time was too long. Feel free to let us know how we can further help bring your contribution back.

Cheers,

@harmstyler

Copy link
Copy Markdown
Author

I closed this one because it was kind of a mess. It contained the merge I did when updating my local copy of eZ Find with the master branch. I intend to redo this commit.

@nfrp

nfrp commented Apr 17, 2013

Copy link
Copy Markdown
Contributor

ok, alright then.

@pkamps

pkamps commented Feb 10, 2015

Copy link
Copy Markdown
Contributor

Too bad, this is a nice idea.

@bdunogier

Copy link
Copy Markdown
Contributor

Well, the branch's still here, Philip, you know what to do... :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants