As an Editor, I want to be able to copy the content type in admin interface by MarioBlazek · Pull Request #1449 · ezsystems/ezplatform-admin-ui

MarioBlazek · 2020-08-14T10:07:26Z

Question	Answer
Tickets	EZP-31801
Bug fix?	no
New feature?	yes
BC breaks?	no
Tests pass?	yes
Doc needed?	no
License	GPL-2.0

This PR implements ContentType copy feature in the admin.

Checklist:

Coding standards ($ composer fix-cs)
Ready for Code Review

MarioBlazek · 2020-08-14T10:12:38Z

PR depends on this ezsystems/ezplatform-kernel#97 as persistence cache doesn't get clear after copy() method, so the listing of content types remains the same.

SylvainGuittard · 2020-08-14T13:43:11Z

Thanks @MarioBlazek for this contribution.
Could you please upload screenshot(s), so we can have a look at the overall design and user experience.

MarioBlazek · 2020-08-17T07:57:34Z

@SylvainGuittard

SylvainGuittard · 2020-08-17T08:59:43Z

Thanks @MarioBlazek

inakijv · 2020-08-17T09:03:44Z

Hi @MarioBlazek thank you for this PR, it is a requested feature that will improve the experience of our users 👍
One thing I am not sure is that if there's a need to create a new column for the "Copy Content Type" button within the table. Other tables in the interface that contain two or more buttons have them within the same column.

inakijv · 2020-08-17T09:04:56Z

                <th class="ez-table__header-cell">{{ 'content_type.view.list.column.id'|trans|desc('ID') }}</th>
                <th class="ez-table__header-cell">{{ 'content_type.view.list.column.modification_date'|trans|desc('Modification date') }}</th>
                <th class="ez-table__header-cell"></th>
+                <th class="ez-table__header-cell"></th>


Not sure if we need to add a new column

MarioBlazek · 2020-08-17T09:05:03Z

@inakijv no problem, I can adjust that.

inakijv · 2020-08-17T09:06:47Z

                <td class="ez-table__cell">{{ content_type.identifier }}</td>
                <td class="ez-table__cell">{{ content_type.id }}</td>
                <td class="ez-table__cell">{{ content_type.modificationDate|ez_full_datetime }}</td>
+                <td class="ez-table__cell ez-table__cell--has-action-btns text-right">


Wouldn't be possible to have the new button within the same column? That way it would look more consitent with other tables in the app

inakijv · 2020-08-17T09:08:20Z

+    <a title="{{ 'content_type.action.copy'|trans|desc('Copy') }}"
+       href="{{ copy_url }}"
+       {% if class_name %}class="{{ class_name }}"{% endif %}>
+        <svg class="ez-icon ez-icon-copy">


I would suggest to add also ez-icon--secondary, given that it is not a primary action. That way it would look more consistent with other tables in the app.

MarioBlazek · 2020-08-17T09:11:21Z

@inakijv @SylvainGuittard adjusted.

adamwojs · 2020-08-17T09:33:18Z

+     *
+     * @throws \eZ\Publish\API\Repository\Exceptions\UnauthorizedException
+     */
+    public function copyAction(ContentTypeGroup $group, ContentType $contentType): Response


Hmmm I'm missing here CSRF protection....

@adamwojs do you have an example of handling the CSRF in the ezplatform-admin-ui?

I can create a simple form in controller to create and validate a CSRF.

Yup, that's what we do too. You could also drop GET action in routing then.

SylvainGuittard · 2020-08-17T11:03:34Z

@MarioBlazek Thanks for adjusting the design. 👍

lserwatka · 2020-09-10T07:59:19Z

@MarioBlazek we would like to include this feature in 3.2. Do you have time to finish it and address changes after code review? Rebase is needed as well.

MarioBlazek · 2020-09-10T08:03:00Z

Sorry, the last few days I was in a rush. Will update this PR tomorrow, the latest.

lserwatka · 2020-09-10T08:04:06Z

@MarioBlazek thank you, this is great contribution, we should use 3.2 window and release it.

lserwatka · 2020-09-10T08:19:22Z

You don't need to fix design, we will take over, as we are in the middle of changing look & feel.

MarioBlazek · 2020-09-11T10:45:36Z

@lserwatka @ViniTou PR updated.

dew326 · 2020-09-11T11:16:20Z

I removed the duplicated table cell.

//cc @lserwatka The new design was already there.

MarioBlazek · 2020-09-11T13:16:35Z

I have just realized that form handling is not working properly. There is already one form for bulk delete out there, so multiple copy forms are added inside it. What do you guys suggest?

dew326 · 2020-09-11T13:24:47Z

But were those forms are added? I can see there is only added the link to the copy route, and in fact, it doesn't work because it redirects to the content types list.

MarioBlazek · 2020-09-11T13:29:15Z

@dew326 I have update the PR with forms. Everything should be ok now. Please review.

dew326 · 2020-09-11T13:30:28Z

                <td class="ez-table__cell">{{ content_type.id }}</td>
                <td class="ez-table__cell">{{ content_type.modificationDate|ez_full_datetime }}</td>
                <td class="ez-table__cell ez-table__cell--has-action-btns">
+                <td class="ez-table__cell ez-table__cell--has-action-btns text-right">


Suggested change

<td class="ez-table__cell ez-table__cell--has-action-btns text-right">

lserwatka · 2020-10-06T19:43:55Z

What is the status here? We are 1 week away from 3.2-rc. If we won't merge it this week, we will need it push it back till December.

ViniTou · 2020-10-07T13:34:24Z

+                        ['%name%' => $contentType->getName()],
+                        'content_type'
+                    );
+                } catch (UnauthorizedException $exception) {


When this exception can occur? Is $this->denyAccessUnlessGranted(new Attribute('class', 'create')); not enough?

ViniTou · 2020-10-07T13:34:38Z


+ezplatform.content_type.copy:
+    path: /contenttypegroup/{contentTypeGroupId}/contenttype/{contentTypeId}/copy
+    methods: ['GET', 'POST']


I would stick with POST only.

adamwojs

+1 besides @ViniTou comments 😉

Nattfarinn

Hmm, user will end up with two Content Types with the very same name. Even if we prefix the name with "Copy" or something, the name will most likely be up to immediate change to something more meaningful. Wouldn't it be better to make it consistent with what we already have in ie. role Copy?

This way would avoid making JS changes to form action and other workarounds for "Form inside Form" issue as well.

Ping: @NataliaBecla @SylvainGuittard

Role copy as reference:

lserwatka · 2020-10-12T07:15:47Z

@Nattfarinn we will address it after RC.

MarioBlazek changed the title ~~Feature: Copy ContentType in admin~~ As an Editor, I want to be able to copy content type Aug 14, 2020

MarioBlazek changed the title ~~As an Editor, I want to be able to copy content type~~ As an Editor, I want to be able to copy the content type in admin interface Aug 14, 2020

inakijv reviewed Aug 17, 2020

View reviewed changes

adamwojs requested a review from a team August 17, 2020 09:17

adamwojs reviewed Aug 17, 2020

View reviewed changes

adamwojs requested a review from a team August 17, 2020 09:43

MarioBlazek force-pushed the feature_content_type_copy branch from 2edd51e to bdf3c59 Compare September 11, 2020 06:55

MarioBlazek force-pushed the feature_content_type_copy branch from 52b3797 to 1bb5d16 Compare September 11, 2020 13:28

dew326 reviewed Sep 11, 2020

View reviewed changes

kaff approved these changes Sep 21, 2020

View reviewed changes

MarioBlazek and others added 11 commits October 7, 2020 12:51

Feature: Copy ContentType in admin

f3686d8

Catch UnauthorizedException exception

526c7fe

Fix CS

d912cfc

Put actions in single column

9a51bb6

Add ez-icon--secondary class

5793b83

Add missing translation

1e69591

Implemented ContentTypeCopyType

d87bb65

Display all content type copy forms

749f581

Fixed CS

1fc3b45

Remove redundant td tag

b1818e4

moved copy form outside delete form

8f7a4e2

dew326 force-pushed the feature_content_type_copy branch from 5da1ca5 to 8f7a4e2 Compare October 7, 2020 11:48

removed console log

af47e76

dew326 requested review from GrabowskiM and OstafinL October 7, 2020 11:55

GrabowskiM approved these changes Oct 7, 2020

View reviewed changes

dew326 requested a review from a team October 7, 2020 12:46

ViniTou reviewed Oct 7, 2020

View reviewed changes

ViniTou requested a review from adamwojs October 7, 2020 13:36

adamwojs approved these changes Oct 7, 2020

View reviewed changes

Nattfarinn suggested changes Oct 7, 2020

View reviewed changes

OstafinL approved these changes Oct 8, 2020

View reviewed changes

lserwatka merged commit e4e2333 into ezsystems:master Oct 12, 2020

Uh oh!

Conversation

MarioBlazek commented Aug 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist:

Uh oh!

MarioBlazek commented Aug 14, 2020

Uh oh!

SylvainGuittard commented Aug 14, 2020

Uh oh!

MarioBlazek commented Aug 17, 2020

Uh oh!

SylvainGuittard commented Aug 17, 2020

Uh oh!

inakijv commented Aug 17, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MarioBlazek commented Aug 17, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MarioBlazek commented Aug 17, 2020

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SylvainGuittard commented Aug 17, 2020

Uh oh!

lserwatka commented Sep 10, 2020

Uh oh!

MarioBlazek commented Sep 10, 2020

Uh oh!

lserwatka commented Sep 10, 2020

Uh oh!

lserwatka commented Sep 10, 2020

Uh oh!

MarioBlazek commented Sep 11, 2020

Uh oh!

dew326 commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarioBlazek commented Sep 11, 2020

Uh oh!

dew326 commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarioBlazek commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lserwatka commented Oct 6, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamwojs left a comment

Choose a reason for hiding this comment

Uh oh!

Nattfarinn left a comment

Choose a reason for hiding this comment

Uh oh!

lserwatka commented Oct 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

MarioBlazek commented Aug 14, 2020 •

edited

Loading

dew326 commented Sep 11, 2020 •

edited

Loading

dew326 commented Sep 11, 2020 •

edited

Loading

MarioBlazek commented Sep 11, 2020 •

edited

Loading