Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29310: Implement permissions for Add Location in Locations tab #515

Merged
merged 1 commit into from Jun 19, 2018

Conversation

mikadamczyk
Copy link
Contributor

Question Answer
Tickets https://jira.ez.no/browse/EZP-29310
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

screen shot 2018-06-19 at 11 13 53 am

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

Copy link
Contributor

@sunpietro sunpietro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little change ;)

<input class="ez-checkbox-icon__checkbox" {{ not location.hidden ? 'checked' }} type="checkbox" name="updateVisibility" value="{{ location.id }}">
<input
class="ez-checkbox-icon__checkbox" {{ not location.hidden ? 'checked' }}
type="checkbox" name="updateVisibility"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name should go into a separate line

@m-tyrala m-tyrala self-assigned this Jun 19, 2018
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approve

@lserwatka lserwatka merged commit 9b09d71 into ezsystems:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants