Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] EZP-28009: Tagged ContentCreation Feature with richtext tag #715

Merged
merged 1 commit into from Nov 19, 2018

Conversation

5 participants
@alongosz
Copy link
Member

commented Nov 13, 2018

Question Answer
Tickets Related to EZP-28009
Related PRs
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR tags ContentCreation Behat tests Feature with @richtext tag as these tests are mostly based on RichText Field type.

This distinction is needed to speed-up running Behat tests for https://github.com/ezsystems/ezplatform-richtext package (see ezsystems/ezplatform-richtext#11). Without that, entire test suite requires ~ 48 minutes to complete executing tests that are not related to RichText feature at all.

Checklist:

  • Add @richtext tag to Behat ContentCreation Feature
  • Ready for Code Review

@alongosz alongosz requested review from m-tyrala, mnocon and micszo Nov 14, 2018

@mnocon

mnocon approved these changes Nov 14, 2018

Copy link
Member

left a comment

As long as it works for you I'm fine with it 😄

@micszo

micszo approved these changes Nov 14, 2018

@m-tyrala
Copy link
Contributor

left a comment

Well ... better than nothing :)

@lserwatka lserwatka merged commit 54fe958 into ezsystems:master Nov 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot/phpcsfixer Code review by ezrobot
Details

@alongosz alongosz deleted the alongosz:ezp-28009-bdd-tag-richtext branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.