Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29902: Admin UI - Locale is not correctly set #756

Merged
merged 2 commits into from Dec 17, 2018

Conversation

@mikadamczyk
Copy link
Contributor

commented Dec 17, 2018

Question Answer
Tickets https://jira.ez.no/browse/EZP-29902
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

screen shot 2018-12-17 at 12 56 16 pm

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mikadamczyk mikadamczyk self-assigned this Dec 17, 2018

@mikadamczyk mikadamczyk requested review from adamwojs, webhdx and ViniTou Dec 17, 2018

@lserwatka

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

@mikadamczyk does it affect 1.3 branch?

@mikadamczyk mikadamczyk changed the base branch from master to 1.3 Dec 17, 2018

@mikadamczyk mikadamczyk force-pushed the mikadamczyk:EZP-29902 branch from c1424ca to 8a4145a Dec 17, 2018

@mikadamczyk

This comment has been minimized.

Copy link
Contributor Author

commented Dec 17, 2018

@lserwatka yes, I changed base

@lserwatka

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

OK, then you must rebase with 1.3 now, so PHPUnit can pass.

@mikadamczyk mikadamczyk force-pushed the mikadamczyk:EZP-29902 branch from 8a4145a to e50adfc Dec 17, 2018

@mikadamczyk mikadamczyk requested a review from kmadejski Dec 17, 2018

@barbaragr barbaragr self-assigned this Dec 17, 2018

@mikadamczyk mikadamczyk force-pushed the mikadamczyk:EZP-29902 branch from e50adfc to 757867a Dec 17, 2018

@barbaragr
Copy link

left a comment

Works fine. Fixes also: https://jira.ez.no/browse/EZP-29726 🎉
After @m-tyrala approve it can be merged.

@m-tyrala

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

That should do the trick once and for all, let's wait for travis tests results.

@lserwatka lserwatka merged commit e57e53d into ezsystems:1.3 Dec 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot/phpcsfixer Code review by ezrobot
Details
@Plopix

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

Install the 1.3.x-dev on my test env where I found the issue and I can confirm the fix as well.

Well done guys! You rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.