Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30032: CustomTags not saved correctly #833

Merged
merged 4 commits into from Feb 12, 2019

Conversation

@mateuszbieniek
Copy link
Contributor

commented Feb 7, 2019

Question Answer
Tickets https://jira.ez.no/browse/EZP-30032
Bug fix? yes
New feature? no
BC breaks? no

This PR adds a line to fire editorInteraction event at the end of CustomTag creation in RichText so AlloyEditor's UI is updated and aware of the changes.

As a side effect this PR fixes also this issue: https://jira.ez.no/browse/EZP-30010

@mateuszbieniek mateuszbieniek added the Bug label Feb 7, 2019

@andrerom andrerom removed their request for review Feb 7, 2019

@@ -210,6 +210,8 @@
*/
setName: function(name) {
this.element.data('ezname', name);
window.clearTimeout(this.setNameFireEditorInteractionTimeout);

This comment has been minimized.

Copy link
@dew326

dew326 Feb 8, 2019

Member

Each timeout handler should be defined at the top (after the editables object).

setNameFireEditorInteractionTimeout: null
@@ -263,6 +265,8 @@
setAlignment: function(type) {
this.wrapper.data(DATA_ALIGNMENT_ATTR, type);
this.element.data(DATA_ALIGNMENT_ATTR, type);
window.clearTimeout(this.setAlignmentFireEditorInteractionTimeout);
this.setAlignmentFireEditorInteractionTimeout = window.setTimeout(this.fireEditorInteraction.bind(this,'aligmentUpdated'), 50);

This comment has been minimized.

Copy link
@dew326

dew326 Feb 8, 2019

Member

Missing space after , in bind(this,'aligmentUpdated'), applies in other cases.

@@ -274,6 +278,8 @@
unsetAlignment: function() {
this.wrapper.data(DATA_ALIGNMENT_ATTR, false);
this.element.data(DATA_ALIGNMENT_ATTR, false);
window.clearTimeout(this.unsetAlignmentFireEditorInteractionTimeout);
this.unsetAlignmentFireEditorInteractionTimeout = window.setTimeout(this.fireEditorInteraction.bind(this,'aligmentRemoved'), 50);

This comment has been minimized.

Copy link
@dew326

dew326 Feb 8, 2019

Member

Those lines seem to be too long. Do you use Prettier?

This comment has been minimized.

Copy link
@mateuszbieniek

mateuszbieniek Feb 8, 2019

Author Contributor

Nope, I will in the future, thanks!

@mateuszbieniek mateuszbieniek force-pushed the mateuszbieniek:EZP-30032 branch from d366606 to c35b8ac Feb 8, 2019

@dew326

dew326 approved these changes Feb 8, 2019

@barbaragr barbaragr self-assigned this Feb 11, 2019

@barbaragr barbaragr added QA approved and removed Ready for QA labels Feb 12, 2019

@lserwatka lserwatka merged commit c9f3de8 into ezsystems:1.4 Feb 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot/phpcsfixer Code review by ezrobot
Details
@lserwatka

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Could you merge it up?

@mateuszbieniek

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

Could you merge it up?

done

@mateuszbieniek mateuszbieniek deleted the mateuszbieniek:EZP-30032 branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.