New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-28273: Make v2 admin sidebar buttons sticky #88

Merged
merged 4 commits into from Dec 18, 2017

Conversation

5 participants
@janit
Member

janit commented Nov 21, 2017

https://jira.ez.no/browse/EZP-28273

In the administration interface the views can be very long. This causes the user to scroll down and then the sidebar buttons are lost. This is especially prominent when editing content with multiple field.

This PR adds a wrapper element and some styles to set the buttons in the sidebar to be sticky when scrolling. See video for a preview - sticky functionality in video has white border.

https://www.youtube.com/watch?v=GZoD7GJ99Y4

@lserwatka lserwatka requested review from sunpietro and dew326 Nov 21, 2017

@lserwatka

This comment has been minimized.

Show comment
Hide comment
@lserwatka

lserwatka Nov 22, 2017

Member

@janit could you amend commit message with JIRA ticket?

Member

lserwatka commented Nov 22, 2017

@janit could you amend commit message with JIRA ticket?

@janit

This comment has been minimized.

Show comment
Hide comment
@janit

janit Nov 22, 2017

Member

Ok, I added the link to the PR description

Member

janit commented Nov 22, 2017

Ok, I added the link to the PR description

@janit

This comment has been minimized.

Show comment
Hide comment
@janit

janit Nov 28, 2017

Member

I looked at this a bit today, but couldn't figure out a smart way to make the extra tools sticky.

The .ez-extra-actions-container seems to be positioned an collapsed underneath the buttons, see image underneath. Do you have any ideas how we could make it sticky and follow?

screen shot 2017-11-28 at 17 06 24

Member

janit commented Nov 28, 2017

I looked at this a bit today, but couldn't figure out a smart way to make the extra tools sticky.

The .ez-extra-actions-container seems to be positioned an collapsed underneath the buttons, see image underneath. Do you have any ideas how we could make it sticky and follow?

screen shot 2017-11-28 at 17 06 24

@dew326

This comment has been minimized.

Show comment
Hide comment
@dew326

dew326 Dec 16, 2017

Member

Branch rebased with master and I fixed the solution.

The sticky container is added for sidebars in:

  • location view
  • content edit/create
  • trash
  • content type edit/create
  • content type group edit/create
  • language edit/create
  • policy edit/create
  • role edit/create
  • role assignment
  • sections edit/create

Known limitation: Sticky container cannot contain bootstrap modal. The modal will be unclickable because it's under the backdrop.

Member

dew326 commented Dec 16, 2017

Branch rebased with master and I fixed the solution.

The sticky container is added for sidebars in:

  • location view
  • content edit/create
  • trash
  • content type edit/create
  • content type group edit/create
  • language edit/create
  • policy edit/create
  • role edit/create
  • role assignment
  • sections edit/create

Known limitation: Sticky container cannot contain bootstrap modal. The modal will be unclickable because it's under the backdrop.

@janit

This comment has been minimized.

Show comment
Hide comment
@janit

janit Dec 17, 2017

Member

Thank you for the improvements @dew326! I tried it on my install and it works just as expected now, so from my part this is good to go.

Member

janit commented Dec 17, 2017

Thank you for the improvements @dew326! I tried it on my install and it works just as expected now, so from my part this is good to go.

@lserwatka lserwatka merged commit 584bea5 into ezsystems:master Dec 18, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot/phpcsfixer Code review by ezrobot
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment