Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30462: Aligned Field Type service tags with new naming convention #15

Merged
merged 1 commit into from Jun 19, 2019

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Jun 18, 2019

Question Answer
JIRA issue EZP-30462
Improvement yes
New feature no
Target version master
BC breaks no
Tests pass yes/no
Doc needed yes

Tags used to register Field Type features in the dependency injection container should be consistent and follow Symfony convention (snake case)

ezpublish.fieldType => ezplatform.field_type
ezpublish.fieldType.indexable => ezplatform.field_type.indexable
ezpublish.storageEngine.legacy.converter => ezplatform.field_type.legacy_storage.converter
ezpublish.fieldType.parameterProvider => ezplatform.field_type.parameter_provider
ezpublish_rest.field_type_processor => ezplatform.field_type.rest.processor
ez.fieldFormMapper.value => ezplatform.field_type.form_mapper.value
ez.fieldFormMapper.definition => ezplatform.field_type.form_mapper.definition

Related PR:
ezsystems/repository-forms#292
ezsystems/ezpublish-kernel#2653

QA: We have to make sure that all field types work correctly

TODO:

  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@micszo micszo self-assigned this Jun 19, 2019
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@micszo micszo removed their assignment Jun 19, 2019
@alongosz alongosz changed the title EZP-30462: Configure Field Type features with tags which follows new convention EZP-30462: Aligned Field Type service tags with new naming convention Jun 19, 2019
@alongosz alongosz merged commit a577f96 into ezsystems:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants