Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EZS-1386] Created base bundle structure #1

Merged
merged 1 commit into from Feb 21, 2017

Conversation

3 participants
@sunpietro
Copy link
Contributor

commented Feb 21, 2017

@sunpietro sunpietro requested review from lserwatka and webhdx Feb 21, 2017

@sunpietro sunpietro force-pushed the bundle-structure branch Feb 21, 2017

bundle/EzSystemsFileUploadBundle.php Outdated
/**
* {@inheritDoc}
*/
class EzSystemsFileUploadBundle extends Bundle

This comment has been minimized.

Copy link
@webhdx

webhdx Feb 21, 2017

Contributor

I'd go with the name EzSystemsMultiFileUploadBundle to differentiate this from the functionality that is already implemented in eZ Platform and also to keep consistency with the repository name. What do you think @sunpietro, @lserwatka? Better consider it throughly now than be stuck with the name forever ;)

This comment has been minimized.

Copy link
@sunpietro

sunpietro Feb 21, 2017

Author Contributor

You're right, good point.

@sunpietro sunpietro force-pushed the bundle-structure branch Feb 21, 2017

@sunpietro

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2017

ping @webhdx

@webhdx

webhdx approved these changes Feb 21, 2017

bundle/DependencyInjection/EzSystemsMultiFileUploadExtension.php Outdated
private function prependYui(ContainerBuilder $container)
{
# Directories where public resources are stored (relative to web/ directory).
$container->setParameter('fu.multifile.upload.public_dir', 'bundles/ezsystemsfileupload');

This comment has been minimized.

Copy link
@kamilmusial

kamilmusial Feb 21, 2017

I'd go multifile_upload.public_dir. Now it looks like upload is one level below multifileand is part of it's config children

This comment has been minimized.

Copy link
@webhdx

webhdx Feb 21, 2017

Contributor

@kamilmusial is right about the parameter name.

From ezsystems/flex-workflow:

$container->setParameter('flex_workflow.public_dir', 'bundles/flexworkflow');

Also bundles/ezsystemsfileupload should be changed to bundles/ezsystemsmultifileupload.

bundle/DependencyInjection/EzSystemsMultiFileUploadExtension.php Outdated
private function prependYui(ContainerBuilder $container)
{
# Directories where public resources are stored (relative to web/ directory).
$container->setParameter('fu.multifile.upload.public_dir', 'bundles/ezsystemsfileupload');

This comment has been minimized.

Copy link
@webhdx

webhdx Feb 21, 2017

Contributor

@kamilmusial is right about the parameter name.

From ezsystems/flex-workflow:

$container->setParameter('flex_workflow.public_dir', 'bundles/flexworkflow');

Also bundles/ezsystemsfileupload should be changed to bundles/ezsystemsmultifileupload.

@sunpietro sunpietro force-pushed the bundle-structure branch Feb 21, 2017

@sunpietro

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2017

@kamilmusial @webhdx done as requested

bundle/DependencyInjection/EzSystemsMultiFileUploadExtension.php Outdated
private function prependYui(ContainerBuilder $container)
{
# Directories where public resources are stored (relative to web/ directory).
$container->setParameter('fu.multifile_upload.public_dir', 'bundles/ezsystemsmultifileupload');

This comment has been minimized.

Copy link
@kamilmusial

kamilmusial Feb 21, 2017

Is fu. necessary?

This comment has been minimized.

Copy link
@sunpietro

sunpietro Feb 21, 2017

Author Contributor

I don't think so. I just wanted to give it a namespace.

This comment has been minimized.

Copy link
@webhdx

webhdx Feb 21, 2017

Contributor

Namespace would be cool but I'd vote for consistency with our other bundles -> better remove fu.

@sunpietro sunpietro force-pushed the bundle-structure branch to 3d02bbd Feb 21, 2017

@webhdx

webhdx approved these changes Feb 21, 2017

@sunpietro sunpietro merged commit ced3a09 into master Feb 21, 2017

@sunpietro sunpietro deleted the bundle-structure branch Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.