Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed content type detection #18

Merged
merged 1 commit into from Apr 11, 2017

Conversation

@sunpietro
Copy link
Contributor

commented Apr 7, 2017

This PR should fix the following issues:

https://jira.ez.no/browse/EZP-27213
https://jira.ez.no/browse/EZP-27214

In case of EZP-27214 a user will see the Unexpected error notification.

@sunpietro sunpietro requested review from dew326, micszo and lserwatka Apr 7, 2017
@sunpietro sunpietro self-assigned this Apr 7, 2017
@sunpietro sunpietro added the Bug label Apr 7, 2017
@sunpietro sunpietro requested a review from pcardiga Apr 7, 2017
errorText = this.get('fileUploadErrorText')
.replace('{message}', `${this._getFileName()} - ${event.message}`);
} else if (event.target) {
console.log('_showFileUploadError', event.target.status);

This comment has been minimized.

Copy link
@dew326

dew326 Apr 7, 2017

Member

console.log

console.log('_showFileUploadError', event.target.status);

let status = event.target.status ? event.target.status : 'N/A';
let message = event.target.status ?

This comment has been minimized.

Copy link
@dew326

dew326 Apr 7, 2017

Member

not sure but it should check if event.target.statusText exists?

@dew326
dew326 approved these changes Apr 7, 2017
@pcardiga

This comment has been minimized.

Copy link

commented Apr 10, 2017

Status so far from QA point of view:
https://jira.ez.no/browse/EZP-27213 - QA approved. The PR solves this issue
https://jira.ez.no/browse/EZP-27214 - Expected behavior clarification request made to @supriyabhargava . See issue for details.
https://jira.ez.no/browse/EZP-27215 - Closed

@lserwatka lserwatka merged commit 8e94d63 into ezsystems:master Apr 11, 2017
@sunpietro sunpietro deleted the sunpietro:fix-detection-content-type branch Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.