Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31933: Fixed custom tag link edit #163

Conversation

SerheyDolgushev
Copy link
Contributor

Question Answer
JIRA issue EZP-31933
Bug/Improvement yes
New feature no
Target version 2.1
BC breaks no
Tests pass yes
Doc needed no

Steps to reproduce

  1. Open any RichText field in Online Editor
  2. Remove all the field content
  3. Insert any custom tag
  4. Make sure there are no empty paragraphs before and after the inserted custom tag
  5. Edit the custom tag
  6. Insert a "test" text
  7. Make the inserted text a link
  8. Chose any location for the link
  9. Click the "Save" link button

Expected result
The link within the custom tag is updated.

Actual result
The link is updated, but Online Editor breaks because of the following JavaScript error:

react-dom.production.min.js:61 Uncaught TypeError: Cannot read property 'lastElement' of null

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform-ee v3.1.2 with diff.

@lserwatka lserwatka merged commit 79d30e6 into ezsystems:2.1 Sep 24, 2020
@lserwatka
Copy link
Member

@dew326 could you merge it up?

@dew326
Copy link
Member

dew326 commented Sep 24, 2020

done

SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Sep 29, 2020
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Sep 29, 2020
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Sep 29, 2020
@SerheyDolgushev SerheyDolgushev mentioned this pull request Sep 29, 2020
4 tasks
lserwatka pushed a commit that referenced this pull request Sep 30, 2020
* Fix related to #149

* Fix related to #163
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Oct 9, 2020
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants