New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed the package to ezplatform-richtext #3
Conversation
25cdb1e
to
a1e1b26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpicks:
.github/pull_request_template.md
Outdated
| **JIRA issue** | [EZP-XXXXX](https://jira.ez.no/browse/EZP-XXXXX) | ||
| **Bug/Improvement**| yes/no | ||
| **New feature** | yes/no | ||
| **Target version** | `6.x`/`7.x` for bug fixes or improvements _(on existing features)_, `master` for features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one still needs adjusting to this package versions.
Suggestion, to avoid updating it every major version let's say there:
latest stable for bug fixes,
master
for new features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
config.php
Outdated
* @copyright Copyright (C) eZ Systems AS. All rights reserved. | ||
* @license For full copyright and license information view LICENSE file distributed with this source code. | ||
* | ||
* @doc Copy this file to config.php to get started! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed, since this actually is config.php
. Ideally I'd get rid of this whole file but I'm assuming copied SetupFactory still needs it here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it should not have been added, as it gets copied by the integration tests :)
docs/Structure.md
Outdated
# RichText structure | ||
|
||
## ezpublish-kernel extraction | ||
This package was extracted from ezsystems/ezpublish-kernel, and remapped to a new structure in its own package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move this to README.md (if it isn't already there).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file wasn't supposed to be added, I'll remove it.
docs/Structure.md
Outdated
This package was extracted from ezsystems/ezpublish-kernel, and remapped to a new structure in its own package. | ||
|
||
## Remapping tasks | ||
- Fix RichText Config Parser test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like thing to be handled via JIRA, I don't like the idea of maintaining it here.
docs/Structure.md
Outdated
@@ -0,0 +1,7 @@ | |||
# RichText structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather handle such small portion of information in README.md
(see also other comments for this file).
Or is there a wider plan for this doc?
log.txt
Outdated
@@ -0,0 +1,40 @@ | |||
236ceeb12883902ce119a42921d5cabd10af7b1a [Structure] Applied php-cs, and enabled in travis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let's rename this file to something more meaningful, like ezpublish-kernel.git.log
.
It's just that if I saw log.txt in the main directory of any repo I'd think that someone commited it by accident 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not meant to be here. I may have used a brutal git add 🗡
6647f2c
to
394f768
Compare
Some changes are required to kernel for the external package to work. In addition, master contains a change to PDO requirements.
394f768
to
af14d98
Compare
Title and story say it all.