Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong solr field name for location priority #28

Merged
merged 1 commit into from Nov 25, 2015

Conversation

4 participants
@harmstyler
Copy link
Contributor

commented Nov 24, 2015

Fixes https://jira.ez.no/browse/EZP-25157

Sort clauses content using \eZ\Publish\API\Repository\Values\Content\Query\SortClause\Location\Priority are ignored by Solr because priority_id doesn't exist.

Wrong solr field name for location priority
Sort clauses content using `\eZ\Publish\API\Repository\Values\Content\Query\SortClause\Location\Priority` are ignored by Solr because `priority_id` doesn't exist.
@andrerom

This comment has been minimized.

Copy link
Member

commented Nov 24, 2015

Hi @harmstyler, cool, +1 from me, just attempting to add test coverage for this before merging, lack of priority in test demo data was the reason why this has/had no coverage.

andrerom added a commit that referenced this pull request Nov 25, 2015

Merge pull request #28 from harmstyler/patch-1
Wrong solr field name for location priority

@andrerom andrerom merged commit 0e3a10b into ezsystems:master Nov 25, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ezrobot Code review by ezrobot
Details
@yannickroger

This comment has been minimized.

Copy link

commented Nov 27, 2015

@andrerom We don't need an issue for it ? Does it impact other branches

@bdunogier

This comment has been minimized.

Copy link
Member

commented Nov 27, 2015

I'll create one.

@bdunogier

This comment has been minimized.

Copy link
Member

commented Nov 27, 2015

Issue created, and added to the PR's description.

@harmstyler harmstyler deleted the harmstyler:patch-1 branch Dec 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.