Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement visiting Criterion\UserMetadata::GROUP target #1045

Merged
merged 3 commits into from Oct 28, 2014

Conversation

2 participants
@pspanja
Copy link
Contributor

commented Oct 22, 2014

This PR resolves https://jira.ez.no/browse/EZP-23400

Ancestor UserGroups ids for the Content owner are indexed and criterion visitor for GROUP target is implemented.

Note that this will require reindexing owner user Content when:

  1. Additional Location for owner user is added
  2. User Location (or subtree) is moved
  3. Parent user Location is swapped
  4. possibly more...

We currently do not implement slots for all of the cases, hence the tests for Solr and ES are intentionally limited until we implement them. We also lack SPI to do implement some of those properly. UserService handles this problem by relying on search, but search should not be used in indexing slots as indexing is asynchronous.

Tests: integration tests.

Follow-up: https://jira.ez.no/browse/EZP-23519

@pspanja

This comment has been minimized.

Copy link
Contributor Author

commented Oct 22, 2014

This has one +1 from ##1038, anyone else up for a review?

Otherwise I'm merging when Travis confirms :)

@andrerom

This comment has been minimized.

Copy link
Member

commented Oct 22, 2014

I see now what you meant by re indexing, any possibility to do a document join in this case? as it is not so common, and we don't need to include the foreign data anyway in the result data.

@pspanja

This comment has been minimized.

Copy link
Contributor Author

commented Oct 22, 2014

@andrerom very hard to do because of arbitrary Location hierarchy... parent/child joins are not all that performant, and if multiple levels are joined (I don't think that can even be done in a dynamic way) the performance would decrease even more. See last section at parent-child practical considerations for more info.

@andrerom

This comment has been minimized.

Copy link
Member

commented Oct 24, 2014

Ok, then +1, but we need a followup story about detecting user location updates and reindexing all content owned to user.

@pspanja

This comment has been minimized.

Copy link
Contributor Author

commented Oct 26, 2014

Follow-up issue created: https://jira.ez.no/browse/EZP-23519

pspanja added a commit that referenced this pull request Oct 28, 2014

Merge pull request #1045 from ezsystems/impl-EZP-23400-visite-usermet…
…adata-group-2

Implement visiting Criterion\UserMetadata::GROUP target

@pspanja pspanja merged commit df5662a into master Oct 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@pspanja pspanja deleted the impl-EZP-23400-visite-usermetadata-group-2 branch Oct 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.