Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FullText.php #1166

Closed
wants to merge 1 commit into from

Conversation

@djoo
Copy link

commented Feb 4, 2015

Hi,

I use the same configuration of the demobundle to my Search Module :
https://github.com/ezsystems/Demo...ster/Controller/SearchController.php
https://github.com/ezsystems/Demo.../blob/master/Helper/SearchHelper.php

When i use my search page, some terms have no results. I don't understand why, in the backend for the same term i have a lot of results.

After research I found that the problem is related to this value searchThresholdValue.

I don't find an other solution that change the value in vendors.

This PR is in link with : http://share.ez.no/forums/ez-publish-5-platform/problem-with-searchhelper-of-demobundle

Thanks

@andrerom

This comment has been minimized.

Copy link
Member

commented Feb 4, 2015

is this configurable via settings? it seems to be injected, but unsure if parent service uses that. ping @pspanja

@pspanja

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2015

@andrerom It is configurable, one can provide settings through configuration that will override default ones in the criterion handler. It would be ideal if it was possible to configure per siteaccess, but we will eventually need to handle different FullText configuration for Legacy, Solr and Elasticsearch search engines, so there would also need to be some kind of resolution on the search engine context. Not sure what you mean by parent service, it is used only in the FullText handler.

@djoo For now you will need to override the FullText criterion handler service and provide the settings that you want to override as a third parameter. See the container configuration for this service: https://github.com/ezsystems/ezpublish-kernel/blob/master/eZ/Publish/Core/settings/storage_engines/legacy/search_query_handlers.yml#L175.

@pspanja

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2015

@andrerom alternatively I thought about providing engine specific configuration on FullText criterion directly.

@andrerom

This comment has been minimized.

Copy link
Member

commented Apr 1, 2015

Closing this in favor of #1218 changing this to use percentage of amount of content like it was in legacy.
Thanks for reporting and pinpointing the issue so precisely!

@andrerom andrerom closed this Oct 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.