Implement EZP-24275: Indexable Image field type #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if ( $fileInfo->isDir() ) | ||
| { | ||
| if ( !self::isIgnoredPath( dirname( $path ) ) ) |
There was a problem hiding this comment.
can't these two if be combined?
There was a problem hiding this comment.
Hi, this part was actually copied from FileSearchBaseIntegrationTest, it is here temporarily until we implement search tests for all field types.
|
+1 |
1 similar comment
|
+1 |
pspanja
force-pushed
the
impl-EZP-24275-indexable-image
branch
from
5cbf8c4
to
713835e
Compare
pspanja
added a commit
that referenced
this pull request
Apr 30, 2015
Implement EZP-24275: Indexable Image field type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves https://jira.ez.no/browse/EZP-24275
A subtask of https://jira.ez.no/browse/EZP-24232
Additionally to the file name, which is the default value used by Field criterion and sort clause, Image field type also indexes alternative text and file size. These can be targeted by using
CustomFieldInterface:: setCustomField()method. Test framework is here refactored to allow testing of these custom fields. However this is a bit awkward, and calls for a refactoring to make testing simpler for the new implementations.Since not all searchable field types have Indexable definition implemented, this required
FileSearchBaseIntegrationTest. This is temporary and will be removed when all searchable field types are covered.Dedicated methods to provide Field search target value was needed, this was taken from #1230.
Solr's base
CriterionVisitornow implementsprepareValue()method, which is used to convert and escape the search target value to the proper Solr representation. This is taken from #1229.Additional fixes
Small bug in Elasticsearch's
FieldRangecriterion visitor, where wrong variable was checked, causingnullto be used as a filter in case when there are no field filters defined. This did not affect the behavior as Elasticsearch seems to be tolerant to it.Followups