Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EZP-24376: Implement language analysis for multicore Solr search engine implementation #1292

Open
wants to merge 6 commits into
base: master
from

Conversation

3 participants
@paulborgermans
Copy link
Contributor

paulborgermans commented Jun 10, 2015

Initial pull request for review

https://jira.ez.no/browse/EZP-24376

@pspanja

This comment has been minimized.

Copy link
Contributor

pspanja commented Jun 10, 2015

Looks good so far, +1 on the approach and placement.

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Jun 11, 2015

also think it looks good so far, I assume by @pspanja comment this is work in progress.
If so please add short task list in description as it will make it clear everywhere that it is work in progress (github will show 1 out of 3 tasks completed on links to the PR, which is very useful), the less review useful alternative convention is to prepend [WIP] in the PR title.

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Jul 29, 2015

Given we are not planning to do any new ezfind releases, does it make sense to move this work to SolrBundle?

@paulborgermans

This comment has been minimized.

Copy link
Contributor Author

paulborgermans commented Jul 29, 2015

@andrerom: I dont see the relation with eZ Find releases, it is pretty generic to configure the Solr backend and the schema in a (several) language specific core(s)

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Jul 29, 2015

Sorry ignore that comment.

What I meant to say is rather:

  • what remains on this functionally? (ref my comment june 11th)
  • also we have moved solr code to own bundle now, so will need to generate diff from this and re apply it there*

* On the plus side this makes it easier to work on Solr, all in one place now as opposed to spread around kernel like it was in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.