Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-25111: Deprecated ViewController location actions #1523

Merged
merged 1 commit into from Dec 8, 2015

Conversation

3 participants
@bdunogier
Copy link
Member

bdunogier commented Dec 1, 2015

@bdunogier bdunogier changed the title EZP-25111: Deprecated ViewController actions EZP-25111: Deprecated ViewController location actions Dec 1, 2015

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Dec 2, 2015

+1 with cs fixes

@@ -144,6 +144,12 @@ protected function buildResponse($etag = null, DateTime $lastModified = null)
*/
public function viewLocation($locationId, $viewType, $layout = false, array $params = array())
{
trigger_error(
"ViewController:viewLocation() is deprecated since kernel 6.0.0, and will be removed in the future.\n" .

This comment has been minimized.

Copy link
@glye

glye Dec 8, 2015

Member

Should be double colon, no? Same for the others. Otherwise +1

@andrerom andrerom force-pushed the ezp25111-location_view_deprecation branch from dd50113 to 8a47383 Dec 8, 2015

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Dec 8, 2015

fixed cs, merge on pass If I have not.

@bdunogier

This comment has been minimized.

Copy link
Member Author

bdunogier commented Dec 8, 2015

Thank you guys.

andrerom added a commit that referenced this pull request Dec 8, 2015

Merge pull request #1523 from ezsystems/ezp25111-location_view_deprec…
…ation

EZP-25111: Deprecated ViewController location actions

@andrerom andrerom merged commit 7f7ad93 into master Dec 8, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot Code review by ezrobot
Details

@andrerom andrerom deleted the ezp25111-location_view_deprecation branch Dec 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.