Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-24732: run normalization even if no XML declaration #1529

Merged
merged 1 commit into from Dec 5, 2015

Conversation

3 participants
@bdunogier
Copy link
Member

bdunogier commented Dec 4, 2015

Fixes https://jira.ez.no/browse/EZP-24732

The normalization done on input XML in #1489 wasn't applied if the XML didn't include an XML declaration tag. PlatformUI doesn't include it.

According to @dpobel, it is optional in XML 1.0 (and according to what I've read online.

Tests

  • Updated unit test
  • Manual test with damien's script
  • Manual CURL test on create content
  • Manual PlatformUI test
@dpobel

This comment has been minimized.

Copy link
Contributor

dpobel commented Dec 4, 2015

+1

1 similar comment
@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Dec 4, 2015

+1

bdunogier added a commit that referenced this pull request Dec 5, 2015

Merge pull request #1529 from ezsystems/ezp24732-html_entities_normal…
…ization

EZP-24732: run normalization even if no XML declaration

@bdunogier bdunogier merged commit 80bf1d0 into master Dec 5, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot Code review by ezrobot
Details

@bdunogier bdunogier deleted the ezp24732-html_entities_normalization branch Dec 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.