Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-25533: Temporary limit FOS HTTP Cache bundle to <= 1.3.6 #1609

Merged
merged 1 commit into from Mar 10, 2016

Conversation

3 participants
@emodric
Copy link
Contributor

emodric commented Mar 9, 2016

This is a temporary solution for 6.1 (and possibly 6.0) branch, in case #1601 is not intended to be backported.

This limits FOS HTTP Cache bundle to version 1.3.6 which does not cause the issue described in https://jira.ez.no/browse/EZP-25533

@bdunogier

This comment has been minimized.

Copy link
Member

bdunogier commented Mar 9, 2016

Looks good to me, +1.

@andrerom ? I think it's good to have it until we fix the hash problem upstream.

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Mar 9, 2016

+1, but it should still require 1.2 or higher.

I guess that will be >=1.2 <=1.3.6

@emodric emodric force-pushed the emodric:patch-1 branch from 307e3aa to e503ff2 Mar 9, 2016

@emodric

This comment has been minimized.

Copy link
Contributor Author

emodric commented Mar 9, 2016

@andrerom You're right. Updated.

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Mar 9, 2016

Thanks :)

@bdunogier

This comment has been minimized.

Copy link
Member

bdunogier commented Mar 9, 2016

Failures are "normal" (e.g. fixed in 162cfd0)

@bdunogier

This comment has been minimized.

Copy link
Member

bdunogier commented Mar 9, 2016

@emodric can you rebase 6.1 please ? I have merged the PR that supposedly fixes behat tests. Then I'll merge.

@emodric emodric force-pushed the emodric:patch-1 branch from e503ff2 to 03374d5 Mar 9, 2016

@emodric

This comment has been minimized.

Copy link
Contributor Author

emodric commented Mar 9, 2016

Done!

@bdunogier

This comment has been minimized.

Copy link
Member

bdunogier commented Mar 10, 2016

Merging, thank you @emodric.

bdunogier added a commit that referenced this pull request Mar 10, 2016

Merge pull request #1609 from emodric/patch-1
EZP-25533: Temporary limit FOS HTTP Cache bundle to <= 1.3.6

@bdunogier bdunogier merged commit 87dd946 into ezsystems:6.1 Mar 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot Code review by ezrobot
Details
@emodric

This comment has been minimized.

Copy link
Contributor Author

emodric commented Mar 10, 2016

Thank you @bdunogier @andrerom !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.