New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] EZP-24842: Add Postgres schema #1794

Closed
wants to merge 4 commits into
base: master
from

Conversation

2 participants
@alongosz
Member

alongosz commented Oct 6, 2016

Status: Postponed untill 7.0
Implements: EZP-24842

Note: we are postponing this PR until we start working on Kernel 7.0. Generic creation of schema is not enough to solve this. We also need to provide cleandata in a more generic way (via Public API?) to properly handle sequences (workaround for resetting them after cleandata import is not the way to do it).

Instead of just adding proper PostgreSQL scripts we decided to create schema using \Doctrine\DBAL\Schema\Schema. To keep code clean schema is created from custom schema.yml file which describes every table. It was created partially using SchemaManager.
This PR also moves data/cleandata.sql to data/mysql/cleandata.sql directory because this SQL script is MySQL-specific.
New script data/postgres/cleandata.sql contains PostgreSQL-specific syntax.

TODO:

  • Rewrite \EzSystems\PlatformInstallerBundle\Installer\CleanInstaller::importSchema to use \Doctrine\DBAL\Schema\Schema and custom data/schema.yml to create database schema.
  • Replace data/cleandata.sql with generic data import (using Public API?) (Kernel 7.0 feature)
  • Replace manually created sequences with proper SERIAL type for PostgreSQL (Possible for kernel 7.0 due to need of BC on 6.x).
  • Avoid SQL in CleanInstaller class (possibly by creating custom class extending \Doctrine\DBAL\Platforms\PostgreSqlPlatform).
  • Test extensively eZ Platform web app using PostgreSQL schema.

@alongosz alongosz added the kernel 7.0 label Oct 12, 2016

@andrerom andrerom modified the milestone: 7.x Nov 23, 2016

@andrerom andrerom removed the kernel 7.0 label Nov 23, 2016

@andrerom andrerom referenced this pull request Jan 7, 2017

Merged

[WIP] 7.0 kernel branch #1875

1 of 3 tasks complete
@alongosz

This comment has been minimized.

Show comment
Hide comment
@alongosz

alongosz Mar 3, 2017

Member

Closing in favor of #1924

Member

alongosz commented Mar 3, 2017

Closing in favor of #1924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment