New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 7.0 kernel branch #1875

Merged
merged 34 commits into from Dec 15, 2017
Commits
Jump to file or symbol
Failed to load files and symbols.
+6 −7
Diff settings

Always

Just for now

Viewing a subset of changes. View all

[BC] Remove usage/support for {}()/\@ in identifiers & remoteIds

  • Loading branch information...
andrerom authored and alongosz committed Jun 12, 2017
commit 23b447a85c98cb7d80e433aba4dcac66af19720b
View
@@ -18,9 +18,8 @@ Changes affecting version compatibility with former or future versions.
somewhat safe, but be on the lookout for nuances in behaviour. If you used Stash features like cache hierarchy,
you'll need to adapt. Recommendation is to adapt to use Symfony Cache, but you can also setup and use Stash yourself.
* "cache_pool" service is now a Symfony 3 Cache Pool instead of Stash. if you type hinted against PSR-6 you should be
somewhat safe, but be on the lookout for nuances in behaviour. If you used Stash features like cache hierarchy,
you'll need to adapt. Recommendation is to adapt to use Symfony Cache, but you can also setup and use Stash yourself.
* Identifiers and remoteIds can no longer contain `{}()/\@` characters as they are not supported in cache keys with
Symfony cache.
* "cache_pool_name" siteaccess setting has been removed & replaced by "cache_service_name" as the semantic is different.
The new setting should contain the full service name of a symfony cache service, by default app_cache.app is used.
@@ -418,7 +418,7 @@ public function testAssignRoleToUser($roleHref)
*/
public function testAssignRoleToUserWithLimitation(array $limitation)
{
$roleHref = $this->createAndPublishRole(__METHOD__ . '_' . $limitation['identifier']);
$roleHref = $this->createAndPublishRole('testAssignRoleToUserWithLimitation_' . $limitation['identifier']);
$xml = <<< XML
<?xml version="1.0" encoding="UTF-8"?>
@@ -82,7 +82,7 @@ public function testRestoreTrashItem($trashItemId)
*/
public function testRestoreTrashItemWithDestination()
{
$trashItemHref = $this->createTrashItem(__FUNCTION__);
$trashItemHref = $this->createTrashItem('testRestoreTrashItemWithDestination');
$request = $this->createHttpRequest('MOVE', $trashItemHref);
$request->addHeader('Destination: /api/ezp/v2/content/locations/1/2');
@@ -113,7 +113,7 @@ public function testDeleteTrashedItemFailsWith404()
self::markTestSkipped('Makes the DB inconsistent');
// create a folder
$folderArray = $this->createFolder(__FUNCTION__, '/api/ezp/v2/content/locations/1/2');
$folderArray = $this->createFolder('testDeleteTrashedItemFailsWith404', '/api/ezp/v2/content/locations/1/2');
// send its main location to trash
$folderLocations = $this->getContentLocations($folderArray['_href']);
@@ -19,7 +19,7 @@ class UrlAliasTest extends RESTFunctionalTestCase
*/
public function testCreateFolder()
{
$folderArray = $this->createFolder(__METHOD__, '/api/ezp/v2/content/locations/1/2');
$folderArray = $this->createFolder('UrlAliasTest_testCreateFolder', '/api/ezp/v2/content/locations/1/2');
$folderLocations = $this->getContentLocations($folderArray['_href']);
return $folderLocations['LocationList']['Location'][0]['_href'];
ProTip! Use n and p to navigate between commits in a pull request.