New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0 Conservative API/Code deprecation removal #2190

Merged
merged 4 commits into from Dec 14, 2017

Conversation

2 participants
@andrerom
Member

andrerom commented Dec 13, 2017

Removes some rather safe things to remove so newcomers to the platform don't end up using things that don't work / is deprecated:

  • Old search indexer commands
  • Never implemented API parts like
    • ContentService:: translateVersion / addTranslationInfo / loadTranslationInfos / newTranslationValues / newTranslationValues
    • FieldTypeTools
    • Values\Content\TranslationInfo & TranslationValues
  • Features deprecated since 5.3 or before:
    • UserGroup->subGroupCount
    • ObjectState[Group]->defaultLanguageCode
    • Values\Content\SearchResult -> Introduce new Trash\SearchResult with full type hinting for Trash item objects instead for findTrashItems() which was still using this, with BC for properties used today
    • Repository->commitEvent()
    • RoleService->removePolicy()

(unit/integration) Tests passes here, but would be best to let #2166 to be merged first once passing, to get all tests to run.

@ezsystems ezsystems deleted a comment from ezrobot Dec 13, 2017

@andrerom andrerom requested review from alongosz, adamwojs and bdunogier Dec 14, 2017

*
* @var int
*/
public $totalCount = 0;

This comment has been minimized.

@adamwojs
@adamwojs

adamwojs Dec 14, 2017

Member

This comment has been minimized.

@andrerom

andrerom Dec 14, 2017

Member

Yes, that adapter is the reason I kept count in here for now, but also for other places that might use it :)

@andrerom

andrerom Dec 14, 2017

Member

Yes, that adapter is the reason I kept count in here for now, but also for other places that might use it :)

@andrerom andrerom merged commit ccc80ae into 7.0 Dec 14, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot/phpcsfixer Code review by ezrobot
Details

@andrerom andrerom deleted the 7.0_deprecation_removal branch Dec 14, 2017

@andrerom

This comment has been minimized.

Show comment
Hide comment
@andrerom

andrerom Dec 14, 2017

Member

All tests passing, included functional ;)

Member

andrerom commented Dec 14, 2017

All tests passing, included functional ;)

wizhippo added a commit to wizhippo/ezpublish-kernel that referenced this pull request Apr 12, 2018

7.0 Conservative API/Code deprecation removal (ezsystems#2190)
* WIP: Conservative 7.0 API deprecation removal

* Add new SearchResult for Trash with same design as being added for URL, keep bc for count param (could not found usage of ->query)

* Fix getMock usage

* Remove remaining TranslationInfo/Value and removePolicy() code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment