EZP-29106: Refactored eZ/Publish/Core/REST/Server/Output/ValueObjectVisitor/** to be able to add custom attributes #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eObjectVisitor/** to be able to add custom attributes in descendants classes
adamwojs
changed the title
Merged
6 tasks
…ut/ValueObjectVisitor/** to be able to add custom attributes in descendants classes
…ut/ValueObjectVisitor/** to be able to add custom attributes in descendants classes
…ut/ValueObjectVisitor/** to be able to add custom attributes in descendants classes
…ut/ValueObjectVisitor/** to be able to add custom attributes in descendants classes
andrerom
approved these changes
May 3, 2018
There was a problem hiding this comment.
+1
Was about to suggest this also for RestExecutedView, for the use case of enhancing Search for SubItems and optionally UDW browse views, but as it visits the content / location values separately, it's perhaps more of an topic for later to extend that somehow, but only for Views when asked for (by custom content type).
micszo
approved these changes
May 4, 2018
alongosz
requested changes
May 7, 2018
| } | ||
|
|
||
| // @todo FIXME: What exception to use? | ||
| throw new \Exception('Undefined version status: ' . $status); |
There was a problem hiding this comment.
\RuntimeException because in this case it would be an internal software error
…ut/ValueObjectVisitor/** to be able to add custom attributes in descendants classes
|
PR updated according to @alongosz suggestions. |
…ut/ValueObjectVisitor/** to be able to add custom attributes in descendants classes
alongosz
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.xPartial refactored eZ/Publish/Core/REST/Server/Output/ValueObjectVisitor/** to be able to add custom attributes in descendants classes
TODO:
$ composer fix-cs).