New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29581: Add cache tags to image variation cache #2437

Merged
merged 1 commit into from Sep 14, 2018

Conversation

4 participants
@emodric
Contributor

emodric commented Sep 5, 2018

Question Answer
JIRA issue EZP-29581
Bug/Improvement yes
New feature no
Target version 7.2
BC breaks no
Tests pass yes
Doc needed no

Currently, to clear image variation caches, one must clear the entire cache, since the caches for variations are not tagged.

This adds various tags to image variation cache items to be able to clear them on demand.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@emodric emodric changed the base branch from master to 7.2 Sep 5, 2018

@emodric

This comment has been minimized.

Show comment
Hide comment
@emodric

emodric Sep 8, 2018

Contributor

First thing Monday :)

Contributor

emodric commented Sep 8, 2018

First thing Monday :)

@emodric

This comment has been minimized.

Show comment
Hide comment
@emodric

emodric Sep 10, 2018

Contributor

@andrerom Updated!

Contributor

emodric commented Sep 10, 2018

@andrerom Updated!

@kmadejski kmadejski requested a review from alongosz Sep 13, 2018

@andrerom andrerom merged commit 7e78b6b into ezsystems:7.2 Sep 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot/phpcsfixer Code review by ezrobot
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment