Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29938: Modified CleanInstaller to use SchemaBuilder #2552

Merged

Conversation

@alongosz
Copy link
Member

commented Mar 3, 2019

Question Answer
JIRA issue EZP-29938
Requires ezsystems/doctrine-dbal-schema#1
Requires (soft) ezsystems/ezplatform#365
Bug/Improvement no
New feature yes
Target version 7.5 for eZ Platform 2.5
BC breaks no
Tests pass yes
Doc needed yes

This PR replaces CleanInstaller with CoreInstaller which uses SchemaBuilder described in ezsystems/doctrine-dbal-schema#1.

If DoctrineSchemaBundle is not enabled, BC CleanInstaller is used. CleanInstaller becomes deprecated.

After these changes the output of the php bin/console ezplatform:install clean command will look like this:

image

TODO:

  • Before merge: remove TMP commit
  • Provide description
  • Implement CoreInstaller which uses SchemaBuilder.
  • Implement SchemaSubscriber which provides core schema.
  • BC: Implement Compiler pass which enables new CoreInstaller only if DoctrineSchemaBundle is enabled.
  • Deprecate CleanInstaller.
  • Prettify installer by adding ProgressBar when executing schema statements`.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@alongosz alongosz force-pushed the alongosz:ezp-29938-install-schema-using-doctrine branch from b1ce7d0 to 32fe29c Mar 4, 2019

@alongosz alongosz marked this pull request as ready for review Mar 4, 2019

@alongosz alongosz force-pushed the alongosz:ezp-29938-install-schema-using-doctrine branch 3 times, most recently from 989c7b2 to 9ead47e Mar 4, 2019

@alongosz

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

Note to reviewers: This PR contains only installer updates, tests will be handled separately, as this caused nightmare yesterday.

@alongosz alongosz force-pushed the alongosz:ezp-29938-install-schema-using-doctrine branch from 9ead47e to 42ceb34 Mar 6, 2019

@alongosz

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

Note: aligned console colors for data installer output for consistency's sake via c825f0a.

@alongosz alongosz force-pushed the alongosz:ezp-29938-install-schema-using-doctrine branch from 42ceb34 to c825f0a Mar 6, 2019

@alongosz alongosz force-pushed the alongosz:ezp-29938-install-schema-using-doctrine branch 2 times, most recently from c402e6f to b7051ba Mar 6, 2019

@mnocon

mnocon approved these changes Mar 6, 2019

Copy link
Member

left a comment

Tested together with: ezsystems/ezplatform#365 , look good 👍

@alongosz alongosz force-pushed the alongosz:ezp-29938-install-schema-using-doctrine branch 2 times, most recently from d67c216 to c1d3daa Mar 9, 2019

@webhdx

webhdx approved these changes Mar 11, 2019

@alongosz alongosz force-pushed the alongosz:ezp-29938-install-schema-using-doctrine branch from c1d3daa to 63527d0 Mar 11, 2019

@alongosz

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

CI failures are related to minimum-stability for doctrine-dbal-schema package and will disappear either after release or once we merge meta (see passing build in the description).

Merging. Huge thanks to all involved 🎉

@alongosz alongosz merged commit 866d977 into ezsystems:master Mar 11, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
ezrobot/phpcsfixer Code review by ezrobot
Details

@alongosz alongosz deleted the alongosz:ezp-29938-install-schema-using-doctrine branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.