Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-20677: Removing users do not clean up ezuser table and urlaliases #298

Merged
merged 8 commits into from Apr 16, 2013

Conversation

@pspanja
Copy link
Contributor

commented Apr 15, 2013

This PR fixes issue https://jira.ez.no/browse/EZP-20677

The issue has two parts:

  1. UserService::deleteUser() did not call UserHandler::delete(), which resulted in user data (ezuser table in Legacy Storage) not being removed
  2. ContentService::deleteContent() did not call UrlAliasHandler::locationDeleted(), resulting in URL aliases for Locations of deleted Content not being disabled

Tests for updated methods are implemented in Core\Repository\Tests\Service\Mock, existing tests duplicated in integration suite are removed.

Additional:

  • after removing User data, SPI cache for corresponding Content is invalidated
@andrerom

This comment has been minimized.

Copy link
Member

commented Apr 15, 2013

+1

andrerom added a commit that referenced this pull request Apr 16, 2013
Merge pull request #298 from ezsystems/fix-EZP-20677-REST-delete-user…
…-cleanup

Fix EZP-20677: Removing users do not clean up ezuser table and urlaliases

@andrerom andrerom merged commit 53898e5 into master Apr 16, 2013

1 check passed

default The Travis build passed
Details

@andrerom andrerom deleted the fix-EZP-20677-REST-delete-user-cleanup branch Apr 16, 2013

@andrerom andrerom restored the fix-EZP-20677-REST-delete-user-cleanup branch Apr 16, 2013

@andrerom andrerom deleted the fix-EZP-20677-REST-delete-user-cleanup branch Apr 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.