Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-22910: Formtoken exception is thrown when logging in without debug redirection #875

Merged
merged 1 commit into from May 26, 2014

Conversation

3 participants
@lolautruche
Copy link
Contributor

commented May 26, 2014

https://jira.ez.no/browse/EZP-22910

Regression from EZP-22767.

LegacyHelper is filled even if the result is an ezpKernelRedirect, triggering a form token exception when request is POST. Makes sense since LegacyHelper uses runCallback() which in this case re-triggers request parsing by the legacy kernel. As request is POST, it legitimately looks for the form token.

For some reason, the issue does not happen with XDebug on.

Fix EZP-22910: Formtoken exception is thrown when logging in without
debug redirection

Regression from [EZP-22767](https://jira.ez.no/browse/EZP-22767).
LegacyHelper is filled even if the result is an ezpKernelRedirect,
triggering a form token exception when request is POST.
Makes sense since LegacyHelper uses runCallback() which in this case
re-triggers request parsing by the legacy kernel. As request is POST, it
legitimately looks for the form token.

For some reason, the issue does not happen with XDebug on.
@andrerom

This comment has been minimized.

Copy link
Member

commented May 26, 2014

+1 (also for stable-5.3, and ping me when cherry picked)

@bdunogier

This comment has been minimized.

Copy link
Member

commented May 26, 2014

+1

@lolautruche lolautruche merged commit 4467532 into master May 26, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@lolautruche lolautruche deleted the fix_EZP-22910_formTokenAgainPissingUsOff branch May 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.