Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix EZP-23170: swapping node with sub items with non-container node. #1032
Problem: swapping a non-container node (class definition) with a node that contains children/sub items will result in an invalid state;
This PR adds an additional check in content/action that prevents the swap if any of the nodes is not a container and the other contains children.
To me is the second. If the operation cannot be done => error. "you cannot swap with this node"
For me, warnings should be for things like "Well, ez Will proceed as you want But note that..." like when you try to clear caches with root account, for instance.
KERNEL_NOT_AVAILABLE is close enough imho.
For canSwap() I think KERNEL_ACCESS_DENIED is right, and it would reflect the use on line 380.
"Content node with ID $selectedNodeID does not exist" is an obvious KERNEL_NOT_AVAILABLE
KERNEL_NOT_AVAILABLE works for me too
2014-07-29 8:36 GMT-05:00 Gunnstein Lye email@example.com:
Twitter : @crevillo
Desarrollador en Tanta Comunicación.