Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-23086: Image thumbnail not shown on backend if alias contains quotes #1038

Merged
merged 1 commit into from Jul 24, 2014

Conversation

4 participants
@dpobel
Copy link
Contributor

dpobel commented Jul 23, 2014

JIRA: https://jira.ez.no/browse/EZP-23086

Description

This PR completes the fix provided in #1019 to correctly handle the case where the URL contains several simple quotes.

Tests

manual tests

Fix EZP-23086: Image thumbnail not shown on backend if alias contains…
… quotes

Additional fix to also handle the case where the URL contains several simple
quotes.
@joaoinacio

This comment has been minimized.

Copy link
Contributor

joaoinacio commented Jul 23, 2014

+1 fwiw

@glye

This comment has been minimized.

Copy link
Member

glye commented Jul 23, 2014

+1

1 similar comment
@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Jul 24, 2014

+1

dpobel added a commit that referenced this pull request Jul 24, 2014

Merge pull request #1038 from ezsystems/ezp-23096_thumbnail_double_si…
…mple_quote

Fix EZP-23086: Image thumbnail not shown on backend if alias contains quotes

@dpobel dpobel merged commit 14a7338 into master Jul 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@dpobel dpobel deleted the ezp-23096_thumbnail_double_simple_quote branch Jul 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.