Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-23254: DFS - tmp files left if the file size is not identical to... #1059

Merged
merged 1 commit into from Aug 14, 2014

Conversation

@yannickroger
Copy link
Contributor

commented Aug 12, 2014

... the original one

Link: https://jira.ez.no/browse/EZP-23254

Decription

This is a follow up of #808. Temp files could still be left out if a corrupted filesystem returned invalid size values.

Tests

Manual tests

@yannickroger

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2014

@jeromegamez

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2014

+1 from me!

@andrerom

This comment has been minimized.

Copy link
Member

commented Aug 13, 2014

+1

@joaoinacio

This comment has been minimized.

Copy link

commented Aug 14, 2014

Looks OK, minor nitpicks: the else is unnecessary (if the if matches it will return anyway)

In addition, it would probably be correct to always remove $filePath at this stage (even if it's not the temp file, it will be corrupt/incorrect as the size is not right), but I guess that's outside the scope of this issue:

// Sizes might have been corrupted by FS problems. Enforcing file removal.
unlink( $filePath );

In any case +1

yannickroger added a commit that referenced this pull request Aug 14, 2014
Merge pull request #1059 from ezsystems/ezp-23254-dfs_file_size_match
Fix EZP-23254: DFS - tmp files left if the file size is not identical to...

@yannickroger yannickroger merged commit c99d47a into master Aug 14, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@yannickroger yannickroger deleted the ezp-23254-dfs_file_size_match branch Aug 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.