New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-23421: Add support for static cache handler system in rss import cronjob part #1086

Merged
merged 1 commit into from Oct 13, 2014

Conversation

4 participants
@brookinsconsulting
Copy link
Contributor

brookinsconsulting commented Oct 5, 2014

Implemented: EZP-23421: Add support for static cache handler system in rss import cronjob part

The problem

Hello,

Recently we tried on a new project to implement delayed to cronjob static caching support for rssimport cronjob imported content. We also implemented a custom static cache handler class and settings changes which work well except in one regard, rssimport of content.

Results were when using rssimport cronjob part the requests to update static cache via delayed to cronjob feature using the staticcache_cleanup cronjob part were not being stored.

This is because the rssimport cronjob part does not support the standard static cache handler system that the rest of the kernel supports. We traced the problem in code to one line 'eZStaticCache::executeActions();' in the cronjobs/rssimport.php file.

The solution

We then wrote replacement code to enable support for the static cache handler system. See pull request file changes diff.

We have created a new issue ticket about this feature request, you can find it here: https://jira.ez.no/browse/EZP-23421

Please review and let us know what you think.

Thank you for your continued support!

Cheers,
Brookins Consulting

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Oct 6, 2014

+1

@brookinsconsulting

This comment has been minimized.

Copy link
Contributor Author

brookinsconsulting commented Oct 7, 2014

Hello @andrerom

Thank you very much for your support. It really means a lot to us.

Please let us know what if anything we can do to help expedite getting these changes into eZ Publish.

Cheers,
Brookins Consulting

@lolautruche lolautruche changed the title Implemented: EZP-23421: Add support for static cache handler system in rss import cronjob part Fix EZP-23421: Add support for static cache handler system in rss import cronjob part Oct 7, 2014

'iniVariable' => 'StaticCacheHandler' );
$options = new ezpExtensionOptions( $optionArray );

This comment has been minimized.

@lolautruche

lolautruche Oct 7, 2014

Contributor

Extra empty line

$options = new ezpExtensionOptions( $optionArray );
$staticCacheHandler = eZExtension::getHandlerClass( $options );

This comment has been minimized.

@lolautruche

lolautruche Oct 7, 2014

Contributor

Extra empty line

@lolautruche

This comment has been minimized.

Copy link
Contributor

lolautruche commented Oct 7, 2014

+1 with empty lines removed 😉

@brookinsconsulting brookinsconsulting force-pushed the brookinsconsulting:static-cache-handler-support branch from dba7a06 to 132d2ca Oct 7, 2014

@brookinsconsulting brookinsconsulting force-pushed the brookinsconsulting:static-cache-handler-support branch from 132d2ca to cac8ca0 Oct 7, 2014

@brookinsconsulting

This comment has been minimized.

Copy link
Contributor Author

brookinsconsulting commented Oct 7, 2014

Hello @lolautruche

Thank you very much for your feedback and review!

We have removed the extra lines, squashed the commits, changed the commit message to match your PR title change and pushed up our branch changes for final review and merging.

We think we did this correctly. Please let us know if we did anything wrong or need to do anything more. This is our second time squashing commits and our first time amending commits :)

Thank you again for your continued support!

Cheers,
Brookins Consulting

yannickroger added a commit that referenced this pull request Oct 13, 2014

Merge pull request #1086 from brookinsconsulting/static-cache-handler…
…-support

Fix EZP-23421: Add support for static cache handler system in rss import cronjob part

@yannickroger yannickroger merged commit d47c54b into ezsystems:master Oct 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@yannickroger

This comment has been minimized.

Copy link
Contributor

yannickroger commented Oct 13, 2014

@brookinsconsulting brookinsconsulting deleted the brookinsconsulting:static-cache-handler-support branch Mar 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment