Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix EZP-23421: Add support for static cache handler system in rss import cronjob part #1086
Conversation
This comment has been minimized.
This comment has been minimized.
|
+1 |
This comment has been minimized.
This comment has been minimized.
|
Hello @andrerom Thank you very much for your support. It really means a lot to us. Please let us know what if anything we can do to help expedite getting these changes into eZ Publish. Cheers, |
brookinsconsulting
referenced this pull request
Oct 7, 2014
Merged
Implemented: Support for static cache handler system #21
lolautruche
changed the title
Implemented: EZP-23421: Add support for static cache handler system in rss import cronjob part
Fix EZP-23421: Add support for static cache handler system in rss import cronjob part
Oct 7, 2014
lolautruche
reviewed
Oct 7, 2014
| 'iniVariable' => 'StaticCacheHandler' ); | ||
| $options = new ezpExtensionOptions( $optionArray ); | ||
This comment has been minimized.
This comment has been minimized.
lolautruche
reviewed
Oct 7, 2014
| $options = new ezpExtensionOptions( $optionArray ); | ||
| $staticCacheHandler = eZExtension::getHandlerClass( $options ); | ||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
+1 with empty lines removed |
brookinsconsulting
force-pushed the
brookinsconsulting:static-cache-handler-support
branch
from
dba7a06
to
132d2ca
Oct 7, 2014
brookinsconsulting
force-pushed the
brookinsconsulting:static-cache-handler-support
branch
from
132d2ca
to
cac8ca0
Oct 7, 2014
This comment has been minimized.
This comment has been minimized.
|
Hello @lolautruche Thank you very much for your feedback and review! We have removed the extra lines, squashed the commits, changed the commit message to match your PR title change and pushed up our branch changes for final review and merging. We think we did this correctly. Please let us know if we did anything wrong or need to do anything more. This is our second time squashing commits and our first time amending commits :) Thank you again for your continued support! Cheers, |
added a commit
that referenced
this pull request
Oct 13, 2014
yannickroger
merged commit d47c54b
into
ezsystems:master
Oct 13, 2014
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Thanks @brookinsconsulting |
brookinsconsulting commentedOct 5, 2014
Implemented: EZP-23421: Add support for static cache handler system in rss import cronjob part
The problem
Hello,
Recently we tried on a new project to implement delayed to cronjob static caching support for rssimport cronjob imported content. We also implemented a custom static cache handler class and settings changes which work well except in one regard, rssimport of content.
Results were when using rssimport cronjob part the requests to update static cache via delayed to cronjob feature using the staticcache_cleanup cronjob part were not being stored.
This is because the rssimport cronjob part does not support the standard static cache handler system that the rest of the kernel supports. We traced the problem in code to one line 'eZStaticCache::executeActions();' in the cronjobs/rssimport.php file.
The solution
We then wrote replacement code to enable support for the static cache handler system. See pull request file changes diff.
We have created a new issue ticket about this feature request, you can find it here: https://jira.ez.no/browse/EZP-23421
Please review and let us know what you think.
Thank you for your continued support!
Cheers,
Brookins Consulting