Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix EZP-23421: Add support for static cache handler system in rss import cronjob part #1086
Implemented: EZP-23421: Add support for static cache handler system in rss import cronjob part
Recently we tried on a new project to implement delayed to cronjob static caching support for rssimport cronjob imported content. We also implemented a custom static cache handler class and settings changes which work well except in one regard, rssimport of content.
Results were when using rssimport cronjob part the requests to update static cache via delayed to cronjob feature using the staticcache_cleanup cronjob part were not being stored.
This is because the rssimport cronjob part does not support the standard static cache handler system that the rest of the kernel supports. We traced the problem in code to one line 'eZStaticCache::executeActions();' in the cronjobs/rssimport.php file.
We then wrote replacement code to enable support for the static cache handler system. See pull request file changes diff.
We have created a new issue ticket about this feature request, you can find it here: https://jira.ez.no/browse/EZP-23421
Please review and let us know what you think.
Thank you for your continued support!
referenced this pull request
Oct 7, 2014
Thank you very much for your feedback and review!
We have removed the extra lines, squashed the commits, changed the commit message to match your PR title change and pushed up our branch changes for final review and merging.
We think we did this correctly. Please let us know if we did anything wrong or need to do anything more. This is our second time squashing commits and our first time amending commits :)
Thank you again for your continued support!