Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix EZP-23908: expiry.php race condition #1139
Restore timestamps before saving, to reduce chance of race condition issues
This is the easy solution. The complete solution would be an asyncronous process with expiry request stored in db and a cron daemon which processes them at short intervals. I consider that overkill for legacy, which should not have new development.
Unknown: How much does this fix affect performance in cluster environments?
referenced this pull request
Jan 20, 2015
No idea about the previous travis fail either, very weird glitch...
Regarding the performance aspect, a possible improvement would be to lazy-load expiry data on the
In any case, this should pretty much resolve the issue - even if it's not 100% fail-safe (no additional locking, etc) I don't see any other solution that wouldn't involve a major rewrite/implementation...