Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-27101 : removing recursionProtect after fetching all metaData of … #1288

Closed
wants to merge 1 commit into from

Conversation

3 participants
@flovntp
Copy link

commented Mar 13, 2017

…a relationList

This solve issue https://jira.ez.no/browse/EZP-27101

@flovntp

This comment has been minimized.

Copy link
Author

commented Mar 13, 2017

my fix remove $GLOBALS["ez_content_object_recursion_protect"] after looping on all contents of a relationList.
Like this, we still avoid adding twice metadata of the same relationList but allow getting metadata in another relationList for the same content.

@pkamps

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2017

Side note: the recursion protection is avoiding infinite loops. For example, if you edit a content object and then select exactly this content object in a objectrelationlist attribute.

I'm able to reproduce the issue. It's maybe a bit of an unusual use case (2 object relation attributes both pointing to the same related object) - but it's definitely a bug.

@pkamps

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2017

There is a problem with this pull request: it is possible to end up in an infinite execution loop.
Here the steps to reproduce the issue:

  • Create a class with 2 objectrelationlist attributes
  • Create an instance (object) of this class
  • Edit the instance and add object relations to both attributes. For both attributes select the content object you currently edit.
  • Hit 'Send for publishing'
@jacek-foremski

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2018

No longer needed because of #1372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.