Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29246: Avoid double decoding of URL #1360

Open
wants to merge 4 commits into
base: master
from

Conversation

2 participants
@pkamps
Copy link
Contributor

commented May 19, 2018

eZSYS::requestURI is already decoding the URL. The eZURI class does it a 2nd time.

Example of the problem. Given URL:
http://sitedomain/(foo)/bar%2Bbar

Double decoded version is is /(foo)/bar bar (that's a space in between)
But the correct value is /(foo)/bar+bar

You can test this by adding following into your pagelayout.tpl:
{$view_parameters|dump()}

Use following URL and look at the dump output:
http://sitedomain/(foo)/bar%2Bbar

The correct value is " /(foo)/bar+bar" - the pull request should produce the correct output.

pkamps added some commits May 19, 2018

Avoid double decoding of URL
eZSYS::requestURI is already decoding the URL. The eZURI class does it a 2nd time.

Example of the problem. Given URL:
http://<sitedomain>/(foo)/bar%2Bbar

Double decoded version is is /(foo)/bar bar (that's a space in between)
But the correct value is /(foo)/bar+bar

You can test this by adding following into your pagelayout.tpl:
{$view_parameters|dump()}

Use following URL and look at the dump output:
http://<sitedomain>/(foo)/bar%2Bbar

The correct value is " /(foo)/bar+bar" - the pull request should produce the correct output.
@pkamps

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2018

@pkamps pkamps changed the title Avoid double decoding of URL EZP-29246: Avoid double decoding of URL May 25, 2018

@pbek

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2018

@pkamps, FYI: I tested your pull request and it didn't solve the issue of showing customer information with urls like https://your-server/admin/shop/customerorderview/10/test%2Btest@test.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.