Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-inforced branding of Community Project- X-Powered-By header #451

Merged
merged 1 commit into from Sep 30, 2012

Conversation

@nfrp
Copy link
Contributor

nfrp commented Sep 30, 2012

No description provided.

nfrp added a commit that referenced this pull request Sep 30, 2012
Re-inforced branding of Community Project- X-Powered-By header
@nfrp nfrp merged commit 4b5b91c into ezsystems:master Sep 30, 2012
@gggeek

This comment has been minimized.

Copy link
Contributor

gggeek commented Oct 1, 2012

+1

I was just wondering if in the "edition" constant we should put the whole name or just the "Community Project" part...

@nfrp

This comment has been minimized.

Copy link
Contributor Author

nfrp commented Oct 1, 2012

I just used the API as present by the time of hacking :)

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Oct 3, 2012

@gggeek Feel free to change it to that in a PR, it's certainly not a bad idea.
If so then we need a constant for product name as well, and a fetch function that concats the product name and edition name for use when you want full name in template.
Downside would be that in the cases like in this PR, then you would need to change it to eZPublishSDK::NAME . ' ' . eZPublishSDK::EDITION

@gggeek

This comment has been minimized.

Copy link
Contributor

gggeek commented Oct 3, 2012

@andrerom ok, but for BC compat I guess I should do this now (before 5.0 is frozen) or never. How much time do I have left?

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Oct 3, 2012

until sunday, deadline is monday, but this would need changes to our build scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.