Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-21358: ezjscAjaxContent: Image's exif fields MakerNote and UserComment must be base64 encoded #707

Merged
merged 1 commit into from Aug 7, 2013

Conversation

4 participants
@yannickroger
Copy link
Contributor

commented Aug 6, 2013

Description

Issue : https://jira.ez.no/browse/EZP-21358

ezjscAjaxContent now returns image's exif fields MakerNote and UserComment base64 encoded.

Test

Manual test on FF and chrome

Fix EZP-21358: ezjscAjaxContent: Image's exif fields MakerNote and Us…
…erComment must be base64 encoded

ezjscAjaxContent now returns image's exif fields MakerNote and UserComment base64 encoded.
@dpobel

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2013

+1

@andrerom

This comment has been minimized.

Copy link
Member

commented Aug 6, 2013

+1, if people want to skip this from the returned value, then a new enhancement for instance introducing a setting + pull request would be the way to go.

@jjCavalleri

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2013

+1 on live tests
(and +1 on your suggestion, AR)

yannickroger added a commit that referenced this pull request Aug 7, 2013

Merge pull request #707 from ezsystems/ezp-21358-exif_base64
Fix EZP-21358: ezjscAjaxContent: Image's exif fields MakerNote and UserComment must be base64 encoded

@yannickroger yannickroger merged commit 6619299 into master Aug 7, 2013

1 check passed

default The Travis CI build passed
Details

@andrerom andrerom deleted the ezp-21358-exif_base64 branch Nov 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.