Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-21324: Fixed missing references to copied image attributes #792

Closed
wants to merge 23 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e60d597
EZP-21324: Fixed missing references to copied image attributes
bdunogier Oct 15, 2013
b76459b
phpdoc
bdunogier Oct 16, 2013
7b90fa5
EZP-21324: Added regression test
bdunogier Oct 17, 2013
2d88774
EZP-21324: Fixed regression when deleting draft
bdunogier Oct 17, 2013
74be141
EZP-21324: changed removeAlias() prototype
bdunogier Oct 17, 2013
06b768c
EZP-21324: Attempt to fix error on postgresql
bdunogier Oct 17, 2013
c594135
Formatting
bdunogier Oct 18, 2013
2b9eb1d
EZP-21324: Fixed postgres error
bdunogier Oct 18, 2013
f35b05c
EZP-21324: Added test scenario for content removal (fails)
bdunogier Oct 18, 2013
870f107
EZP-21324: fixed removeAllAliases()
bdunogier Oct 18, 2013
9825308
EZP-21324: Added test for remove image object
bdunogier Oct 18, 2013
afd8f1c
EZP-21324: Refactored removal of aliases
bdunogier Oct 18, 2013
11cbcce
EZP-21324: Fixed image alias purging
bdunogier Oct 18, 2013
025376a
EZP-21324: tests (failing)
bdunogier Oct 18, 2013
b7f74c0
EZP-21324: Prevented duplicates in ezimagefile
bdunogier Oct 18, 2013
a18307d
EZP-21324: tests
bdunogier Oct 18, 2013
102748b
Added test for eZCache::purgeImageAlias
bdunogier Oct 19, 2013
e570262
EZP-21324: Fixed eZImageType::postStore()
bdunogier Oct 19, 2013
7618517
EZP-21324: Added test case to removeCopy
bdunogier Oct 19, 2013
b6b2245
EZP-21342: Fixed an edge case in removeAliasFile()
bdunogier Oct 20, 2013
e6f5d4d
EZP-21324: Added a test case (fails)
bdunogier Oct 20, 2013
a063d7d
EZP-21324: Fixed test case tested in the previous commit
bdunogier Oct 20, 2013
14932cd
EZP-21324: phpdoc
bdunogier Oct 28, 2013
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

EZP-21324: fixed removeAllAliases()

We just don't use it anymore. removeAliases() does the job.
The only difference is that removeAliases() will set the
attribute's XML to an empty value, while removeAllAliases()
won't, meaning that the change will create a light overhead
on the database.
  • Loading branch information...
bdunogier committed Oct 18, 2013
commit 870f1078723906a3cc8405d8241e64dba91c1189
@@ -175,17 +175,10 @@ public function restoreTrashedObjectAttribute( $contentObjectAttribute )
function deleteStoredObjectAttribute( $contentObjectAttribute, $version = null )
{
if ( $version === null )
{
eZImageAliasHandler::removeAllAliases( $contentObjectAttribute );
}
else
{
/** @var eZImageAliasHandler $imageHandler */
$imageHandler = $contentObjectAttribute->attribute( 'content' );
if ( $imageHandler )
$imageHandler->removeAliases();
}
/** @var eZImageAliasHandler $imageHandler */
$imageHandler = $contentObjectAttribute->attribute( 'content' );
if ( $imageHandler )
$imageHandler->removeAliases();
}
/**
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.